Skip to content

Commit 33146c0

Browse files
committed
Merge from gz-launch7
Signed-off-by: Ian Chen <ichen@openrobotics.org>
2 parents f0875c3 + 0851899 commit 33146c0

File tree

6 files changed

+12
-18
lines changed

6 files changed

+12
-18
lines changed

.github/ci/packages.apt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,14 @@ binutils-dev
22
libgflags-dev
33
libgz-cmake4-dev
44
libgz-common6-dev
5-
libgz-fuel-tools10-dev
65
libgz-sim9-dev
76
libgz-gui9-dev
87
libgz-math8-dev
98
libgz-math8-eigen3-dev
109
libgz-msgs11-dev
11-
libgz-physics8-dev
1210
libgz-plugin3-dev
13-
libgz-rendering9-dev
14-
libgz-sensors9-dev
1511
libgz-tools2-dev
1612
libgz-transport14-dev
17-
libsdformat15-dev
1813
libtinyxml2-dev
1914
libwebsockets-dev
2015
libxi-dev

CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,8 @@ gz_create_docs(
133133
TAGFILES
134134
"${GZ-MATH_DOXYGEN_TAGFILE} = ${GZ-MATH_API_URL}"
135135
"${GZ-MSGS_DOXYGEN_TAGFILE} = ${GZ-MSGS_API_URL}"
136-
"${GZ-PHYSICS_DOXYGEN_TAGFILE} = ${GZ-PHYSICS_API_URL}"
137136
"${GZ-PLUGIN_DOXYGEN_TAGFILE} = ${GZ-PLUGIN_API_URL}"
138137
"${GZ-TRANSPORT_DOXYGEN_TAGFILE} = ${GZ-TRANSPORT_API_URL}"
139-
"${GZ-SENSORS_DOXYGEN_TAGFILE} = ${GZ-SENSORS_API_URL}"
140138
"${GZ-COMMON_DOXYGEN_TAGFILE} = ${GZ-COMMON_API_URL}"
141139
"${GZ-SIM_DOXYGEN_TAGFILE} = ${GZ-SIM_API_URL}"
142140
"${GZ-GUI_DOXYGEN_TAGFILE} = ${GZ-GUI_API_URL}"

package.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,10 @@
1313
<depend>binutils</depend>
1414
<depend>gz-cmake4</depend>
1515
<depend>gz-common6</depend>
16-
<depend>gz-fuel-tools9</depend>
1716
<depend>gz-gui9</depend>
1817
<depend>gz-math8</depend>
1918
<depend>gz-msgs11</depend>
20-
<depend>gz-physics7</depend>
2119
<depend>gz-plugin3</depend>
22-
<depend>gz-rendering8</depend>
23-
<depend>gz-sensors8</depend>
2420
<depend>gz-sim9</depend>
2521
<depend>gz-tools2</depend>
2622
<depend>gz-transport14</depend>
@@ -29,7 +25,6 @@
2925
<depend>libxi-dev</depend>
3026
<depend>libxmu-dev</depend>
3127
<depend>libyaml-dev</depend>
32-
<depend>sdformat14</depend>
3328
<depend>tinyxml2</depend>
3429
<depend>uuid</depend>
3530

plugins/joy_to_twist/JoyToTwist.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#endif
2323

2424
#include <string>
25+
#include <vector>
2526

2627
#include <gz/msgs/joy.pb.h>
2728
#include <gz/msgs/twist.pb.h>

plugins/websocket_server/WebsocketServer.cc

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -624,9 +624,14 @@ void WebsocketServer::Run()
624624

625625
while (this->run)
626626
{
627-
// The second parameter is a timeout that is no longer used by
628-
// libwebsockets.
629-
lws_service(this->context, 0);
627+
// The second parameter is used to control lws's event wait time.
628+
// A -1 does not wait for an event, and 0 causes lws to wait
629+
// for an event. When shutting down the websocket server, the
630+
// wait time could be over 30 seconds if 0 is used.
631+
//
632+
// We are running lws in a separate thread with out our own
633+
// condition variable. So, we will not use lws's event wait.
634+
lws_service(this->context, -1);
630635

631636
// Wait for (1/60) seconds or an event.
632637
std::unique_lock<std::mutex> lock(this->runMutex);

src/cmd/cmdlaunch.rb.in

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
require 'pathname'
1718
# Constants.
1819
LIBRARY_VERSION = '@PROJECT_VERSION_FULL@'
1920
COMMANDS = {
@@ -28,9 +29,8 @@ class Cmd
2829
command = args[0]
2930
exe_name = COMMANDS[command]
3031

31-
if exe_name[0] == '/'
32-
# If the first character is a slash, we'll assume that we've been given an
33-
# absolute path to the executable. This is only used during test mode.
32+
if Pathname.new(exe_name).absolute?
33+
# The exe_name can be absolute path during test. We'll leave it unchanged
3434
else
3535
# We're assuming that the library path is relative to the current
3636
# location of this script.

0 commit comments

Comments
 (0)