We love pull requests. We strive to promptly review them, provide feedback, and merge. This document describes how to get yours merged quickly.
We use the Apache 2.0 License. Before we can merge a pull request, we require a signed Contributor License Agreement. This can be emailed to cla@agi.com, and only needs to be completed once. The CLA ensures you retain copyright to your contributions, and we have the right to use them and incorporate them into Cesium. There is a CLA for:
- individuals and
- corporations.
Please email a completed CLA with all fields filled in to cla@agi.com. Related questions are also welcome.
To keep our code quality high, please make sure:
- Your code follows the coding conventions.
- Your code passes JSHint. We use the JSHint Eclipse plugin so it runs automatically when we save. You can also run the
jsHint
Ant task from the command line. - To include tests with excellent code coverage for new features. We use Jasmine for writing tests. Run them by browsing to http://localhost:8080/Specs/SpecRunner.html. Verify all new and existing tests pass. For bonus points, test Chrome, Firefox, and other browsers supporting WebGL.
- To update LICENSE.md if third-party libraries were added/updated/removed, including new version of existing libraries. Mention it in CHANGES.md.
If new public classes, functions, or properties were added, also:
- Include reference documentation with code examples. Check out the best practices.
- Update CHANGES.md.
- If the change is significant, add a new Sandcastle example or extend and existing one.
See the Contributor's Guide for how to get the code and setup a development environment, and see CONTRIBUTORS.md for the current list of contributors.