Skip to content

Commit 695748b

Browse files
committed
Addons: Remove obsolete GTK_CHECK_VERSION checks
1 parent 3e38966 commit 695748b

File tree

3 files changed

+1
-34
lines changed

3 files changed

+1
-34
lines changed

addons/src/addons.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -652,9 +652,7 @@ static GtkWidget *plugin_addons_configure(G_GNUC_UNUSED GeanyPlugin *plugin, Gtk
652652

653653
gtk_widget_show_all(vbox);
654654

655-
#if ! GTK_CHECK_VERSION(2, 10, 0)
656655
gtk_widget_hide(check_systray);
657-
#endif
658656

659657
return vbox;
660658
}

addons/src/ao_doclist.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,8 @@ static void ao_popup_position_menu(GtkMenu *menu, gint *x, gint *y, gboolean *pu
141141
/* Get the root coordinates of the toolbar's window */
142142
int wx_root, wy_root, width;
143143
window = gtk_widget_get_window (gtk_widget_get_ancestor(widget, GTK_TYPE_TOOLBAR));
144-
#if GTK_CHECK_VERSION(3, 0, 0)
145144
gdk_window_get_geometry(window, &wx, &wy, &width, NULL);
146145
gtk_widget_get_preferred_size(widget, &widget_req, NULL);
147-
#else
148-
gdk_window_get_geometry(window, &wx, &wy, &width, NULL, NULL);
149-
gtk_widget_size_request(widget, &widget_req);
150-
#endif
151146
gdk_window_get_root_coords(window, wx, wy, &wx_root, &wy_root);
152147

153148
/* Approximate the horizontal location of the overflow menu button */
@@ -173,11 +168,7 @@ static void ao_popup_position_menu(GtkMenu *menu, gint *x, gint *y, gboolean *pu
173168
else
174169
gdk_window_get_origin(window, &wx, &wy);
175170
}
176-
#if GTK_CHECK_VERSION(3, 0, 0)
177171
gtk_widget_get_preferred_size(widget, &widget_req, NULL);
178-
#else
179-
gtk_widget_size_request(widget, &widget_req);
180-
#endif
181172
widget_height = widget_req.height; /* Better than allocation.height */
182173

183174
/* Calculate menu position */
@@ -270,13 +261,7 @@ static gboolean ao_create_proxy_menu_cb(GtkToolItem *widget, gpointer data)
270261
/* Create the menu item if needed */
271262
if (priv->overflow_menu_item == NULL)
272263
{
273-
#if GTK_CHECK_VERSION(3, 0, 0)
274264
priv->overflow_menu_item = gtk_menu_item_new_with_label("Document List");
275-
#else
276-
GtkWidget *menu_image = gtk_image_new_from_icon_name(GTK_STOCK_INDEX, GTK_ICON_SIZE_MENU);
277-
priv->overflow_menu_item = gtk_image_menu_item_new_with_label("Document List");
278-
gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(priv->overflow_menu_item), menu_image);
279-
#endif
280265
g_signal_connect(priv->overflow_menu_item, "activate",
281266
G_CALLBACK(ao_toolbar_item_doclist_clicked_cb), data);
282267
}
@@ -306,10 +291,8 @@ static void ao_toolbar_update(AoDocList *self)
306291
if (priv->toolbar_doclist_button == NULL)
307292
{
308293
priv->toolbar_doclist_button = gtk_tool_button_new_from_stock(GTK_STOCK_INDEX);
309-
#if GTK_CHECK_VERSION(2, 12, 0)
310294
gtk_tool_item_set_tooltip_text(GTK_TOOL_ITEM(priv->toolbar_doclist_button),
311295
_("Show Document List"));
312-
#endif
313296
plugin_add_toolbar_item(geany_plugin, priv->toolbar_doclist_button);
314297
ui_add_document_sensitive(GTK_WIDGET(priv->toolbar_doclist_button));
315298

addons/src/ao_systray.c

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ struct _AoSystrayPrivate
4545
gboolean enable_systray;
4646

4747
GtkWidget *popup_menu;
48-
#if GTK_CHECK_VERSION(2, 10, 0)
4948
GtkStatusIcon *icon;
50-
#endif
5149
};
5250

5351
enum
@@ -68,12 +66,10 @@ G_DEFINE_TYPE(AoSystray, ao_systray, G_TYPE_OBJECT)
6866

6967
static void ao_systray_finalize(GObject *object)
7068
{
71-
#if GTK_CHECK_VERSION(2, 10, 0)
7269
AoSystrayPrivate *priv = AO_SYSTRAY_GET_PRIVATE(object);
7370

7471
g_object_unref(priv->icon);
7572
g_object_unref(priv->popup_menu);
76-
#endif
7773

7874
G_OBJECT_CLASS(ao_systray_parent_class)->finalize(object);
7975
}
@@ -88,9 +84,7 @@ static void ao_systray_set_property(GObject *object, guint prop_id,
8884
{
8985
case PROP_ENABLE_SYSTRAY:
9086
priv->enable_systray = g_value_get_boolean(value);
91-
#if GTK_CHECK_VERSION(2, 10, 0)
9287
gtk_status_icon_set_visible(priv->icon, priv->enable_systray);
93-
#endif
9488
break;
9589
default:
9690
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
@@ -121,7 +115,6 @@ static void ao_systray_class_init(AoSystrayClass *klass)
121115
}
122116

123117

124-
#if GTK_CHECK_VERSION(2, 10, 0)
125118
static void icon_activate_cb(GtkStatusIcon *status_icon, gpointer data)
126119
{
127120
if (gtk_window_is_active(GTK_WINDOW(geany->main_widgets->window)))
@@ -135,7 +128,7 @@ static void icon_popup_menu_cmd_clicked_cb(GtkMenuItem *item, gpointer data)
135128
{
136129
GtkWidget *widget;
137130
const gchar *widget_name = NULL;
138-
131+
139132
switch (GPOINTER_TO_INT(data))
140133
{
141134
case WIDGET_OPEN:
@@ -178,12 +171,10 @@ static void icon_popup_menu_cb(GtkStatusIcon *status_icon, guint button, guint a
178171
if (button == 3)
179172
gtk_menu_popup(GTK_MENU(priv->popup_menu), NULL, NULL, NULL, NULL, button, activate_time);
180173
}
181-
#endif
182174

183175

184176
static void ao_systray_init(AoSystray *self)
185177
{
186-
#if GTK_CHECK_VERSION(2, 10, 0)
187178
AoSystrayPrivate *priv = AO_SYSTRAY_GET_PRIVATE(self);
188179
GtkWidget *item;
189180
const gchar *icon_name;
@@ -196,11 +187,7 @@ static void ao_systray_init(AoSystray *self)
196187
gtk_status_icon_set_from_pixbuf(priv->icon, gtk_window_get_icon(
197188
GTK_WINDOW(geany->main_widgets->window)));
198189

199-
#if GTK_CHECK_VERSION(2, 16, 0)
200190
gtk_status_icon_set_tooltip_text(priv->icon, "Geany");
201-
#else
202-
gtk_status_icon_set_tooltip(priv->icon, "Geany");
203-
#endif
204191

205192
priv->popup_menu = gtk_menu_new();
206193
g_object_ref_sink(priv->popup_menu);
@@ -238,7 +225,6 @@ static void ao_systray_init(AoSystray *self)
238225

239226
g_signal_connect(priv->icon, "activate", G_CALLBACK(icon_activate_cb), NULL);
240227
g_signal_connect(priv->icon, "popup-menu", G_CALLBACK(icon_popup_menu_cb), self);
241-
#endif
242228
}
243229

244230

0 commit comments

Comments
 (0)