New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Death animation does not end properly. #19

Open

AlejoAsd opened this issue Feb 6, 2018 · 1 comment

Labels

bug

Member

AlejoAsd commented Feb 6, 2018

When dying, the character disappears after playing the whole animation.

AlejoAsd added bug good first issue labels

Member Author

AlejoAsd commented Feb 10, 2018 •

edited

Loading

This is because kill is being called and super.kill() is called within it, killing the sprite.

However, if kill is removed the animation loops endlessly. I believe this is happening because there's a loop:

Collision with lava calls kill.
kill checks that the controller is enabled, plays the death animation and calls disableController.
Some external code is calling enableController. This reactivates the collision loop and the cycle repeats itself from step 1.

AlejoAsd removed the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment