Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RHEA or EC to populate definitions #29650

Open
pgaudet opened this issue Feb 3, 2025 · 0 comments
Open

Use RHEA or EC to populate definitions #29650

pgaudet opened this issue Feb 3, 2025 · 0 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Feb 3, 2025

from #29562 (comment)

@cmungall

I think in this case the original GO def was just outright wrong and despite the provenance was neither sourced from EC or RHEA. I think this must just have been a copy and paste typo.

But here is what I propose moving forward:

every catalytic activity has a single source of truth (SoT); i.e ONE def_xref to EITHER EC or RHEA
exceptions should only be care cases where neither EC nor RHEA concept is appropriate and we make some kind of synthesis, and GO editors are the SoT. These should be rare, if they happen at all.
We automatically sync all definitions where there is a single SoT. We don't try and write complex string matching (e.g for + vs (+) and the many other chemical lexicogoraphy edge cases), and we don't use LLMs. We just drop and reload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants