-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"NADP biosynthetic process" logical definition #29666
Comments
Hi @ukemi The LD has: That looks right - did you use CHEBI:58349 in your model? |
@sjm41 Thanks for checking this! No, I used [CHEBI:18009] NADP(+), my bad. I corrected this now, but it's still not consistent with the textual def, don't you think? |
Is it possible to have a LD that says: ?? Looking at the current terms, I'm guessing LDs including 'or' are not possible, and it looks like there was a decision to standardize on just stating the oxidized form in the LDs for the NAD/NADP BP terms. Here's the essential bits of the current entry for the record: id: GO:0006741 |
Or ask ChEBI for 'NADP(H) anion'? or have NADP(H) only refer to the ph7.3 forms? |
Thanks @cmungall The conjugate relations looks fine. The issue is that while ChEBI has the concept of NAD(P), NAD(P)H and NAD(P)+, i.e. to cover both phosphorylated/unphosphorylated NAD, it doesn't have the concept of NADP(H), which would cover both oxidized and reduced forms of NAD. The text def of GO:0006741 NADP biosynthetic process (and related terms) say it covers both NADP+ and NADPH synthesis, so ideally the ChEBI in the LD would match that. I don't see ChEBI making a single term for NADP(3-)/NADPH(4-). |
If I create a construct of 'biosynthetic process' has_primary_output some NADP+ in a GO-CAM, it is not inferred to be an NADP biosynthetic process. Based on the definition this term refers to both the biosynthesis of NADP+ and NADPH. The ontology group needs to check the differentia of the logical definition.
The text was updated successfully, but these errors were encountered: