Skip to content

Commit 0ab116e

Browse files
committed
PB-2064: fix timeslider tests
1 parent 22ee1b1 commit 0ab116e

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

packages/viewer/src/router/legacyPermalink.routerPlugin.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ export function handleLegacyParam(
182182
newValue = legacyParamValue
183183
break
184184
}
185-
console.log('handleLegacyParam', legacyParamName, legacyParamValue, key, newValue)
186185
if (newValue !== undefined) {
187186
// When receiving a query, the application will encode the URI components
188187
// We decode those so that the new query won't encode encoded character

packages/viewer/src/store/modules/layers/getters/oldestYear.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ export default function oldestYear(this: LayersStore): number {
99
if (!layer.timeConfig || !timeConfigUtils.hasMultipleTimestamps(layer)) {
1010
return oldestYear
1111
}
12-
const sortedEntries = layer.timeConfig.timeEntries.sort((a, b) => Number(a.year) - Number(b.year)).slice(-1)[0]!
12+
const sortedEntries = layer.timeConfig.timeEntries.sort((a, b) => Number(b.year) - Number(a.year)).slice(-1)[0]!
1313
const oldestLayerYear: number | undefined = timeConfigUtils.getYearFromLayerTimeEntry(
1414
sortedEntries
1515
)
16+
1617
if (oldestLayerYear && oldestYear > oldestLayerYear) {
1718
return oldestLayerYear
1819
}

packages/viewer/src/store/modules/layers/getters/youngestYear.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ export default function youngestYear(this: LayersStore): number {
1616
if (b.year === undefined) {
1717
return -1
1818
}
19-
return Number(a.year) - Number(b.year)
19+
return Number(b.year) - Number(a.year)
2020
})[0]!
2121
const youngestLayerYear: number | undefined = timeConfigUtils.getYearFromLayerTimeEntry(
2222
sortedEntries
2323
)
24+
2425
if (youngestLayerYear && youngestYear < youngestLayerYear) {
2526
return youngestLayerYear
2627
}

packages/viewer/tests/cypress/tests-e2e/timeSlider.cy.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ describe('Cypress tests covering the time slider, its functionalities and its UR
132132

133133
cy.goToMapView({
134134
queryParams: {
135+
// layers: `${timedLayerIdWithAllYear}@year=2009`,
135136
layers: `${timedLayerId}@year=2019,f,;${timedLayerIdWithOddYear}@year=2009;${timedLayerIdWithAllYear}@year=2009`,
136137
timeSlider: 2013,
137138
},
@@ -190,6 +191,7 @@ describe('Cypress tests covering the time slider, its functionalities and its UR
190191
}
191192
})
192193
})
194+
cy.log('Closing the odd year layer time selector', timedLayerIdWithAllYear)
193195
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
194196
cy.get(`[data-cy="time-selector-${timedLayerIdWithAllYear}-2"]`).should(
195197
'contain',

0 commit comments

Comments
 (0)