PB-1383: fix debounce generic

Make it returns the same function type/signature as the one given as input

Author: pakb

packages/viewer/src/modules/drawing/components/DrawingToolbox.vue

@@ -162,8 +162,7 @@ function onDeleteLastPoint() {
     emits('removeLastPoint')
 }
 
-const debounceSaveDrawingName = debounce((...args: unknown[]) => {
-    const newName = typeof args[0] === 'string' ? args[0] : undefined
+function saveDrawingName(newName?: string) {
     const sanitized = DOMPurify.sanitize(newName ?? '', {
         ALLOWED_TAGS: [],
         ALLOWED_ATTR: [],
@@ -173,7 +172,9 @@ const debounceSaveDrawingName = debounce((...args: unknown[]) => {
     debounceSaveDrawing().catch((error: Error) =>
         log.error(`Error while saving drawing after name change: ${error}`)
     )
-}, 200)
+}
+
+const debounceSaveDrawingName = debounce(saveDrawingName, 200)
 </script>
 
 <template>

packages/viewer/src/modules/infobox/components/styling/FeatureStyleEdit.vue

@@ -134,9 +134,8 @@ function updateFeatureDescription(): void {
     )
 }
 
-type DebouncedFn = (..._args: unknown[]) => void
-const debounceTitleUpdate: DebouncedFn = debounce(updateFeatureTitle, 100)
-const debounceDescriptionUpdate: DebouncedFn = debounce(updateFeatureDescription, 300)
+const debounceTitleUpdate = debounce(updateFeatureTitle, 100)
+const debounceDescriptionUpdate = debounce(updateFeatureDescription, 300)
 
 function handleKeydown(event: KeyboardEvent): void {
     if (event.key === 'Delete' && !isEditingText.value) {

packages/viewer/src/modules/map/components/toolbox/TimeSlider.vue

@@ -221,9 +221,7 @@ function dispatchPreviewYearToStore() {
     setPreviewYearToLayers()
 }
 
-const dispatchPreviewYearToStoreDebounced = debounce(() => {
-    dispatchPreviewYearToStore()
-}, 100)
+const dispatchPreviewYearToStoreDebounced = debounce(dispatchPreviewYearToStore, 100)
 
 function setSliderWidth() {
     const padding = 112

packages/viewer/src/modules/menu/components/activeLayers/TransparencySlider.vue

@@ -30,7 +30,7 @@ function saveOpacityToLayer(opacity: number): void {
     layersStore.setLayerOpacity(index, opacity, dispatcher)
 }
 
-const debouncedSaveOpacityToLayer = debounce(() => saveOpacityToLayer, 50)
+const debouncedSaveOpacityToLayer = debounce(saveOpacityToLayer, 50)
 
 watch(localTransparency, (newTransparency) => {
     const newOpacity = 1 - newTransparency

packages/viewer/src/modules/menu/components/search/SearchResultList.vue

@@ -110,40 +110,37 @@ const isLocationSearchResult = (entry: SearchResult): entry is LocationSearchRes
 
 // We debounce the preview to avoid too many store dispatch
 const PREVIEW_DEBOUNCING_DELAY = 50
-const setPreviewDebounced = debounce(
-    () => (entry: SearchResult) => {
-        log.debug({
-            messages: [
-                `Set preview`,
-                entry,
-                previewLayer.value ?? '',
-                previewedPinnedLocation.value?.toString(),
-            ],
-        })
-
-        if (!entry) {
-            if (previewLayer.value) {
-                layersStore.clearPreviewLayer(dispatcher)
-            }
-            if (previewedPinnedLocation.value) {
-                mapStore.clearPreviewPinnedLocation(dispatcher)
-            }
-        } else if (entry.resultType === SearchResultTypes.LAYER) {
-            layersStore.setPreviewLayer(entry.id, dispatcher)
-
-            if (previewedPinnedLocation.value) {
-                mapStore.clearPreviewPinnedLocation(dispatcher)
-            }
-        } else if (isLocationSearchResult(entry)) {
-            mapStore.setPreviewedPinnedLocation(entry.coordinate, dispatcher)
-
-            if (previewLayer.value) {
-                layersStore.clearPreviewLayer(dispatcher)
-            }
+const setPreviewDebounced = debounce((entry?: SearchResult) => {
+    log.debug({
+        messages: [
+            `Set preview`,
+            entry,
+            previewLayer.value ?? '',
+            previewedPinnedLocation.value?.toString(),
+        ],
+    })
+
+    if (!entry) {
+        if (previewLayer.value) {
+            layersStore.clearPreviewLayer(dispatcher)
         }
-    },
-    PREVIEW_DEBOUNCING_DELAY
-)
+        if (previewedPinnedLocation.value) {
+            mapStore.clearPreviewPinnedLocation(dispatcher)
+        }
+    } else if (entry.resultType === SearchResultTypes.LAYER) {
+        layersStore.setPreviewLayer(entry.id, dispatcher)
+
+        if (previewedPinnedLocation.value) {
+            mapStore.clearPreviewPinnedLocation(dispatcher)
+        }
+    } else if (isLocationSearchResult(entry)) {
+        mapStore.setPreviewedPinnedLocation(entry.coordinate, dispatcher)
+
+        if (previewLayer.value) {
+            layersStore.clearPreviewLayer(dispatcher)
+        }
+    }
+}, PREVIEW_DEBOUNCING_DELAY)
 
 defineExpose({ focusFirstEntry })
 </script>