Editor: Service as resource layer suggestion #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlitaBernachot
changed the title
|
Affected libs:
|
|
📷 Screenshots are here! |
AlitaBernachot
force-pushed
the
service-layer-suggestion
branch
5 times, most recently
from
10ad151 to
86a745a
Compare
jahow
reviewed
Feb 10, 2025
Comment on lines
51
to
61
| function wmsLayerFlatten(layerFull) { | ||
| const layer = { | ||
| title: layerFull.title, | ||
| name: layerFull.name, | ||
| abstract: layerFull.abstract, | ||
| } | ||
|
|
||
| return 'children' in layerFull && Array.isArray(layerFull.children) | ||
| ? [layer, ...layerFull.children.flatMap(wmsLayerFlatten)] | ||
| : [layer] | ||
| } |
There was a problem hiding this comment.
One day it'd be great to have this in ogc-client, but this can wait 🙂
There was a problem hiding this comment.
New PR in ogc-client: camptocamp/ogc-client#89
...rc/lib/components/online-service-resource-input/online-service-resource-input.component.html
Outdated
Show resolved
Hide resolved
...rc/lib/components/online-service-resource-input/online-service-resource-input.component.html
Outdated
Show resolved
Hide resolved
AlitaBernachot
force-pushed
the
service-layer-suggestion
branch
3 times, most recently
from
0d6132f to
53e59ad
Compare
AlitaBernachot
force-pushed
the
service-layer-suggestion
branch
from
53e59ad to
e1b60d7
Compare
AlitaBernachot
force-pushed
the
service-layer-suggestion
branch
from
e1b60d7 to
82df975
Compare
AlitaBernachot
force-pushed
the
service-layer-suggestion
branch
from
fa4b19a to
c9f4177
Compare
jahow
approved these changes
Feb 11, 2025
Comment on lines
+274
to
+275
| const endpointWmts = new WmtsEndpoint(url) | ||
| await endpointWmts.isReady() |
There was a problem hiding this comment.
FYI you can also do const endpoint = await new WmtsEndpoints(url).isReady()
No need to change it here, just for next time ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the service as resource form by adding layer suggestion as a dropdown list.
OGC, WMS,WMTS, WFS are supported. For other protocol, a simple input text is displayed in place of the dropdown.
You can find some services here: https://camptocamp.github.io/ogc-client/#/ or https://geoservices.ign.fr/documentation/services/services-geoplateforme/diffusion#70064
Architectural changes
None
Screenshots
Also added a use case: custom validate icon in storybook for url-input-component
Quality Assurance Checklist
breaking changelabelbackport <release branch>label