feat: remove old iframe header

f-necas · f-necas · commit 4c53fb0b1f22 · 2023-12-01T14:19:45.000+01:00
diff --git a/apps/datafeeder/src/app/app.component.html b/apps/datafeeder/src/app/app.component.html
@@ -1,7 +1 @@
-<iframe
-  [style.height]="headerHeight"
-  [src]="headerSrc | safe: 'resourceUrl'"
-  scrolling="no"
-  frameborder="0"
-></iframe>
 <router-outlet></router-outlet>
diff --git a/apps/datafeeder/src/app/app.component.spec.ts b/apps/datafeeder/src/app/app.component.spec.ts
@@ -2,7 +2,6 @@ import { TestBed } from '@angular/core/testing'
 import { RouterTestingModule } from '@angular/router/testing'
 import { AppComponent } from './app.component'
 import { UtilSharedModule } from '@geonetwork-ui/util/shared'
-import SETTINGS from '../settings'
 
 describe('AppComponent', () => {
   beforeEach(async () => {
@@ -25,11 +24,5 @@ describe('AppComponent', () => {
     it(`should have as title 'datafeeder'`, () => {
       expect(app.title).toEqual('datafeeder')
     })
-    it(`should have SETTINGS.headerHeight as height`, () => {
-      expect(app.headerHeight).toEqual(SETTINGS.headerHeight)
-    })
-    it(`should have SETTINGS.headerSrc as src`, () => {
-      expect(app.headerSrc).toEqual(SETTINGS.headerSrc)
-    })
   })
 })
diff --git a/apps/datafeeder/src/app/app.component.ts b/apps/datafeeder/src/app/app.component.ts
@@ -1,6 +1,5 @@
 import { Component, OnInit } from '@angular/core'
 import { ThemeService } from '@geonetwork-ui/util/shared'
-import SETTINGS from '../settings'
 
 @Component({
   selector: 'gn-ui-root',
@@ -9,8 +8,6 @@ import SETTINGS from '../settings'
 })
 export class AppComponent implements OnInit {
   title = 'datafeeder'
-  headerSrc = SETTINGS.headerSrc
-  headerHeight = SETTINGS.headerHeight
 
   ngOnInit() {
     ThemeService.applyCssVariables('#1EA9D5', '#EF7749', '#2E353A', '#fff')
diff --git a/apps/datafeeder/src/index.html b/apps/datafeeder/src/index.html
@@ -11,6 +11,10 @@
       href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@400;700&family=Permanent+Marker&display=swap"
       rel="stylesheet"
     />
+    <link
+      href="https://fonts.googleapis.com/icon?family=Material+Icons|Material+Icons+Outlined"
+      rel="stylesheet"
+    />
     <script src="assets/env.js"></script>
   </head>
   <body class="m-0 h-full flex flex-col">
diff --git a/apps/datafeeder/src/settings.ts b/apps/datafeeder/src/settings.ts
@@ -4,8 +4,6 @@ import { environment } from './environments/environment'
 const SETTING_API = `${environment.apiUrl}/config/frontend`
 
 class Settings {
-  headerHeight = '90px'
-  headerSrc = '/header/?active=import'
   encodings = [
     {
       label: 'UTF-8',

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,6 @@ import { environment } from './environments/environment'`
`4`	`4`	const SETTING_API = `${environment.apiUrl}/config/frontend`
`5`	`5`
`6`	`6`	`class Settings {`
`7`		`- headerHeight = '90px'`
`8`		`- headerSrc = '/header/?active=import'`
`9`	`7`	`encodings = [`
`10`	`8`	`{`
`11`	`9`	`label: 'UTF-8',`