Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin not fully aligned with 2024.02 extension #206

Open
Gaetanbrl opened this issue Dec 23, 2024 · 1 comment
Open

Plugin not fully aligned with 2024.02 extension #206

Gaetanbrl opened this issue Dec 23, 2024 · 1 comment

Comments

@Gaetanbrl
Copy link

Gaetanbrl commented Dec 23, 2024

Hi !

I had tried MapStoreExtension release v2024.02.02 and all package.json commands works fine.

This is not true with mapstore2-cadastrapp cmd with node 16 (same with node 20) :

  • npm run ext:start - FAIL (due to unexpected fontawesome error)
  • npm run ext:startapp - FAIL
  • npm run start - SUCCESS

Next (and not really a trouble), package.json is not align with MapStoreExtension (e.g fe:start is not same, be:xxx commands missing).

This has been reproduced with branch :

About gh actions, build commands works and is not concerned by this issue (i guess).

Expected

  • mapstore2-cadastrapp works like v2024.02.02 MapStoreExtension tag / release.
  • all of package.json commands must work

Install process

nvm use 16
git clone --recursive https://github.com/georchestra/mapstore2-cadastrapp
npm install

FAIL (works with MapStoreExtension not with mapstore2-cadastrapp) :

npm run ext:start
npm run ext:startapp

SUCCESS :
npm run start

Error

With mapstore2-cadastrapp :

npm run ext:start

modules by path ./lib/*./lib/locales (ignored) 30 bytes
  ./lib/locales (ignored) 15 bytes [built] [code generated]
  ./lib/locales (ignored) 15 bytes [built] [code generated]
12 modules

ERROR in ./node_modules/font-awesome/fonts/fontawesome-webfont.woff?v=4.7.0 1:4
Module parse failed: Unexpected character '' (1:4)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)
 @ ./node_modules/css-loader/dist/cjs.js!./node_modules/font-awesome/css/font-awesome.min.css 7:0-86 14:73-102
 @ ./node_modules/font-awesome/css/font-awesome.min.css 2:12-88 9:17-24 13:7-21 45:20-34 49:6-59:7 50:38-52 56:26-40 58:21-28 68:15-29 47:4-60:5
 @ ./MapStore2/web/client/utils/styleparser/StyleParserUtils.js 887:9-56
 @ ./MapStore2/web/client/utils/styleparser/LeafletStyleParser.js 32:0-149 107:11-20 123:25-51 127:28-52 155:28-52 181:22-46 233:36-56 251:36-56 288:30-50 297:29-55 325:37-63
 @ ./MapStore2/web/client/utils/VectorStyleUtils.js 68:11-53
 @ ./MapStore2/web/client/components/map/openlayers/Feature.jsx 33:0-68 88:25-42 91:25-42
 @ ./MapStore2/web/client/components/map/plugins/openlayers.js 14:13-56
 @ ./MapStore2/web/client/components/map/plugins/ lazy ^\.\/.*\.js$ chunkName: map-library-[request] namespace object ./openlayers.js
 @ ./MapStore2/web/client/components/map/enhancers/mapType.js 72:10-102
 @ ./MapStore2/web/client/components/widgets/widget/MapView.jsx 13:0-50 18:93-100
 @ ./js/extension/components/landedproperty/MapView.jsx 9:0-66 27:27-34
 @ ./js/extension/components/landedproperty/Content.jsx 8:0-32 53:38-45
 @ ./js/extension/components/landedproperty/Modal.jsx 21:0-32 157:38-45
 @ ./js/extension/plugins/cadastrapp/LandedProperty.jsx 17:0-83 60:42-72
 @ ./js/extension/plugins/cadastrapp/Main.jsx 10:0-46 49:194-208
 @ ./js/extension/plugins/Extension.jsx 6:0-37 47:13-17
 @ container entry ./plugin[0]

ERROR in ./node_modules/font-awesome/fonts/fontawesome-webfont.woff2?v=4.7.0 1:4
Module parse failed: Unexpected character '' (1:4)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)
 @ ./node_modules/css-loader/dist/cjs.js!./node_modules/font-awesome/css/font-awesome.min.css 6:0-87 13:73-102
 @ ./node_modules/font-awesome/css/font-awesome.min.css 2:12-88 9:17-24 13:7-21 45:20-34 49:6-59:7 50:38-52 56:26-40 58:21-28 68:15-29 47:4-60:5
 @ ./MapStore2/web/client/utils/styleparser/StyleParserUtils.js 887:9-56
 @ ./MapStore2/web/client/utils/styleparser/LeafletStyleParser.js 32:0-149 107:11-20 123:25-51 127:28-52 155:28-52 181:22-46 233:36-56 251:36-56 288:30-50 297:29-55 325:37-63
 @ ./MapStore2/web/client/utils/VectorStyleUtils.js 68:11-53
 @ ./MapStore2/web/client/components/map/openlayers/Feature.jsx 33:0-68 88:25-42 91:25-42
 @ ./MapStore2/web/client/components/map/plugins/openlayers.js 14:13-56
 @ ./MapStore2/web/client/components/map/plugins/ lazy ^\.\/.*\.js$ chunkName: map-library-[request] namespace object ./openlayers.js
 @ ./MapStore2/web/client/components/map/enhancers/mapType.js 72:10-102
 @ ./MapStore2/web/client/components/widgets/widget/MapView.jsx 13:0-50 18:93-100
 @ ./js/extension/components/landedproperty/MapView.jsx 9:0-66 27:27-34
 @ ./js/extension/components/landedproperty/Content.jsx 8:0-32 53:38-45
 @ ./js/extension/components/landedproperty/Modal.jsx 21:0-32 157:38-45
 @ ./js/extension/plugins/cadastrapp/LandedProperty.jsx 17:0-83 60:42-72
 @ ./js/extension/plugins/cadastrapp/Main.jsx 10:0-46 49:194-208
 @ ./js/extension/plugins/Extension.jsx 6:0-37 47:13-17
 @ container entry ./plugin[0]

webpack 5.54.0 compiled with 2 errors in 95121 ms
ℹ 「wdm」: Failed to compile.

@Gaetanbrl Gaetanbrl changed the title Plugin not fully aligned with 2024.02 Plugin not fully aligned with 2024.02 extension Dec 23, 2024
@Gaetanbrl
Copy link
Author

Gaetanbrl commented Dec 23, 2024

I see the same thing about SVG when i read this code (i dunno if it works better in recent MapStoreExtension version) :

We can't use .SVG in mapstore2-cadastrapp. How to use it now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant