Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-209 - Resize of plot panel navigation #210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LPoin
Copy link
Contributor

@LPoin LPoin commented Jan 23, 2025

Fix the plot panel size according to search plot tab and save space.

@LPoin LPoin marked this pull request as draft January 23, 2025 14:04
@LPoin LPoin marked this pull request as ready for review January 23, 2025 14:07
@landryb
Copy link
Member

landryb commented Jan 23, 2025

there's some improvement here with that PR:
image

but .. not there yet.
image

@landryb landryb linked an issue Jan 23, 2025 that may be closed by this pull request
@landryb
Copy link
Member

landryb commented Jan 23, 2025

to me that's this class (as seen from firefox devtools) that adds too much padding around the tab title:

.geOrchestra .nav > li > a {
  padding: 10px 15px;
}

but from my understanding thats a class from the mapstore css, not the extension css. or the padding should be set to less in the added class ?

im definitely not a css wizard, but changing the above class to set 2px 5px might not be pixel perfect, but it aligns more with the other tabs size..

@LPoin
Copy link
Contributor Author

LPoin commented Jan 24, 2025

Modified. Let me know if it's good for you.

image

@landryb
Copy link
Member

landryb commented Jan 24, 2025

thanks, i've retested it here and it looks great now !

one 'funny' thing i noted on the way, if you have 'selection 1' and 'selection 2' tabs, and close 'selection 1', it will .. 'rename' the 'selection 2' tab to 'selection 1'. But the tabs created from a search by plot dont change name and keep the commune name/insee code in their title, so i guess the tabs being renamed are... a minor UX inconsistency ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize of plot panel navigation
2 participants