Use tiff tag types from tiff crate #11
Merged
+159
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIFF decoding and encoding library in pure Rust! Repo at https://github.com/image-rs/image-tiff
Reduce confusion when using the `tiff` crate later.
Remove the TagType enum in src/lowlevel.rs, use tiff:tags:Type instead (https://docs.rs/tiff/0.9.1/tiff/tags/enum.Type.html). Added support for IFD, LONG8, SLONG8 and IFD8 types.
Remove the & from the match statements. Xref https://rust-lang.github.io/rust-clippy/master/index.html#/match_ref_pats
weiji14
commented
May 16, 2024
Comment on lines
+144
to
+147
| Type::IFD => unimplemented!(), | ||
| Type::LONG8 => unimplemented!(), | ||
| Type::SLONG8 => unimplemented!(), | ||
| Type::IFD8 => unimplemented!(), |
There was a problem hiding this comment.
TODO implement TagValue enum variants for these, probably in a separate PR, as will likely need some upstream changes in the tiff crate.
Also bumped up version in badge from v0.0.1 to v0.0.2 to match that in crates.io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
tiffcrate as a dependency (per #7), and doing some slight refactoring to use thetiff:tags:Typeenum instead of defining it in-house.Note that this also adds partial support for
IFD,LONG8,SLONG8andIFD8variant types (untested).TODO:
tiffcrate to Cargo.tomlsrc/tiff.rstosrc/geotiff.rsto reduce naming confusiontiff::tags::Typeenum instead ofcrate::lowlevel::TagTypetiffcrate