Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded maps - details loads panel even if the details attribute value is NODATA #10544

Closed
1 task done
tdipisa opened this issue Sep 16, 2024 · 0 comments · Fixed by #10548 or #10558
Closed
1 task done

Embedded maps - details loads panel even if the details attribute value is NODATA #10544

tdipisa opened this issue Sep 16, 2024 · 0 comments · Fixed by #10548 or #10558
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C044-VLAANDEREN-2024-SUPPORT
Milestone
2024.02.00

Comments

@tdipisa
Copy link
Member

tdipisa commented Sep 16, 2024

Description

The fix provided for #10318 doesn't cover the embedded maps

How to reproduce

Expected Result

Details button should not be available in nav toolbar

Current Result

Details button should is in nav toolbar

image

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@tdipisa tdipisa added this to the 2024.02.00 milestone Sep 16, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 16, 2024
@mahmoudadel54
geosolutions-it#10544: fix Embedded maps - details loads panel even i…
6faddcd 
…f the details attribute value is NODATA

Description:
- adding check of no data condition for show/hide details panel in toolbar
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 16, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 16, 2024 that will close this issue
#10544: fix Embedded maps - details loads panel even if the details attribute value is NODATA #10548
Merged
12 tasks
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 16, 2024
MV88 pushed a commit that referenced this issue Sep 16, 2024
@mahmoudadel54
#10544: fix Embedded maps - details loads panel even if the details a…
c4c5d4b 
…ttribute value is NODATA (#10548)

Description:
- adding check of no data condition for show/hide details panel in toolbar
@ElenaGallo ElenaGallo self-assigned this Sep 18, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 18, 2024
@mahmoudadel54
geosolutions-it#10544: fix Embedded maps - details loads panel even i…
7027859 
…f the details attribute value is NODATA (geosolutions-it#10548)

Description:
- adding check of no data condition for show/hide details panel in toolbar
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 18, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 18, 2024 that will close this issue
[Backport 2024.02.xx] - #10544: fix Embedded maps - details loads panel even if the details attribute value is NODATA (#10548) #10558
Merged
tdipisa pushed a commit that referenced this issue Sep 19, 2024
@mahmoudadel54
#10544: fix Embedded maps - details loads panel even if the details a…
fe9f97f 
…ttribute value is NODATA (#10548) (#10558)

Description:
- adding check of no data condition for show/hide details panel in toolbar
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 19, 2024
offtherailz pushed a commit that referenced this issue Oct 18, 2024
@mahmoudadel54 @offtherailz
#10544: fix Embedded maps - details loads panel even if the details a…
04dd991 
…ttribute value is NODATA (#10548)

Description:
- adding check of no data condition for show/hide details panel in toolbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C044-VLAANDEREN-2024-SUPPORT
Projects
None yet
Milestone
2024.02.00
4 participants
@tdipisa @MV88 @ElenaGallo @mahmoudadel54