Fixing hstring

gershnik · gershnik · commit 67df4f821425 · 2024-11-15T03:42:00.000-08:00
diff --git a/lib/inc/sys_string/impl/platforms/windows_hstring.h b/lib/inc/sys_string/impl/platforms/windows_hstring.h
@@ -439,7 +439,8 @@ namespace sysstr::util
     template<util::ct_string Str>
     inline auto make_static_sys_string_hstring() noexcept -> sys_string_hstring
     {
-        static struct bug_workaround { const hstring_header header{1, Str.size() - 1, 0, 0, Str.chars}; } b;
+        constexpr size_t size = Str.size();
+        static struct bug_workaround { const hstring_header header{1, size - 1, 0, 0, Str.chars}; } b;
         return sys_string_hstring(HSTRING(uintptr_t(&b.header) | hstring_static_allocation_bit) , handle_retain::no);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,8 @@ namespace sysstr::util`
`439`	`439`	`template<util::ct_string Str>`
`440`	`440`	`inline auto make_static_sys_string_hstring() noexcept -> sys_string_hstring`
`441`	`441`	`{`
`442`		`- static struct bug_workaround { const hstring_header header{1, Str.size() - 1, 0, 0, Str.chars}; } b;`
	`442`	`+ constexpr size_t size = Str.size();`
	`443`	`+ static struct bug_workaround { const hstring_header header{1, size - 1, 0, 0, Str.chars}; } b;`
`443`	`444`	`return sys_string_hstring(HSTRING(uintptr_t(&b.header) \| hstring_static_allocation_bit) , handle_retain::no);`
`444`	`445`	`}`
`445`	`446`	`}`