Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce semver compatbility check in app #2328

Closed
bonomat opened this issue Mar 26, 2024 · 2 comments
Closed

Introduce semver compatbility check in app #2328

bonomat opened this issue Mar 26, 2024 · 2 comments
Labels
good-first-issue Good for newcomers Stale

Comments

@bonomat
Copy link
Contributor

bonomat commented Mar 26, 2024

We introduced semver versioning with #2326 and said that patch versions should be compatible with each other.

We have a similar check on the app which is now wrong:

final response = await http.get(
Uri.parse('http://${config.host}:${config.httpPort}/api/version'),
);
final clientVersion = Version.parse(packageInfo.version);
final coordinatorVersion = CoordinatorVersion.fromJson(jsonDecode(response.body));
logger.i("Coordinator version: ${coordinatorVersion.version.toString()}");

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 26, 2024
@bonomat bonomat added good-first-issue Good for newcomers and removed Stale labels Apr 26, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

1 participant