Merge pull request #191 from getgauge/fix-paramater-conversion

Check if parameter is number before Number.parse

Author: zabil

.github/workflows/nodejs.yml

@@ -68,7 +68,7 @@ jobs:
           mv ./gauge-ts-*.tgz ./gauge-ts/artifacts
 
       - name: Upload artifacts for local
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
           name: gauge-ts
           path: ./gauge-ts/artifacts
@@ -93,7 +93,7 @@ jobs:
           npm ci
           npm run build
 
-      - uses: actions/download-artifact@v1
+      - uses: actions/download-artifact@v4
         with:
           name: gauge-ts
           path: ./artifacts

e2e/specs/parameters.spec

@@ -6,4 +6,5 @@
 
 ## Custom Parameters in steps
 
-* This step uses a custom parameter of type Person and value "{\"name\":\"John\",\"age\":30}"
+* Convert custom parameter of type Person and value "{\"name\":\"John\",\"age\":30}"
+* Check strings with numbers for example "3 % 4" is correct

e2e/tests/parameter.ts

@@ -8,10 +8,14 @@ export default class Parameter {
     assert.strictEqual(original.trim(), expected);
   }
 
-  @Step("This step uses a custom parameter of type Person and value <person>")
+  @Step("Convert custom parameter of type Person and value <person>")
   public async validatePerson(person: Person) {
     assert.strictEqual(person.name, "John");
     assert.strictEqual(person.age, 30);
     assert.ok(person.isAdult());
   }
+  @Step("Check strings with numbers for example <value> is correct")
+  async checkStringConversion(value: string) {
+    assert.strictEqual(value, "3 % 4");
+  }
 }

gauge-ts/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gauge-ts",
-  "version": "0.3.4",
+  "version": "0.3.5",
   "description": "Typescript runner for Gauge",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

gauge-ts/src/processors/params/PrimitiveParser.ts

@@ -27,8 +27,11 @@ export class PrimitiveParser implements ParameterParser {
   }
 
   private convertToNumber(value: string): number | undefined {
-    const num = Number.parseFloat(value);
-    return Number.isNaN(num) ? undefined : num;
+    if (value.trim() === "") {
+      return undefined;
+    }
+    const num = Number(value);
+    return Number.isFinite(num) ? num : undefined;
   }
 
   private convertToBoolean(value: string): boolean | undefined {

gauge-ts/ts.json

@@ -16,6 +16,6 @@
     "linux": ["./launcher.mjs", "--start"],
     "windows": ["launcher.bat", "--start"]
   },
-  "version": "0.3.4",
+  "version": "0.3.5",
   "gRPCSupport": true
 }