Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github note: false issue #1

Open
gojennie opened this issue Jun 11, 2019 · 2 comments
Open

Github note: false issue #1

gojennie opened this issue Jun 11, 2019 · 2 comments

Comments

@gojennie
Copy link

gojennie commented Jun 11, 2019

Setting note to false does not remove the Github note on the bottom of every docs:
Found errors? Think you can improve this documentation? Simply click the Edit link at the top of the page, and then the icon on Github to make your changes.

Reproduce:

  1. Go to /your/folder/user/themes/learn4
  2. Edit learn4.yaml
  3. Set it to :
    github:
    note: false
    link: true
  4. Go to /your/folder/user/config/themes
  5. Repeat Can't install with Admin or GPM #2-3

Right now, I just edited /your/folder/user/themes/learn4/templates/docs.html.twig as a workaround.
Maybe I missed something, if so let me know!

@rhukster
Copy link
Member

Learn4 was rebuilt on top of learn3 (which in turn was built on learn2). However, it's not polished and old settings are not removed. That's why it's not released or available in GPM yet :)

@gojennie
Copy link
Author

gojennie commented Jun 11, 2019

Oh okay understood that's not a problem. Love the new theme so I'm using it as my personal website. Thank you~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants