Ansible generating various minor warnings and isn't fully idempotent

[robmccardle]

Ansible generating various minor warnings and isn't fully idempotent

Type

• Feature Request

Environment

• Operating System: Ubuntu trusty64 VM (Vagrant local on Mac and in Travis container)
• Node version: n/a
• NPM version: n/a
• Version / Commit hash: 7af8e02

Expected behaviour

No warnings should be generated by Ansible. Idempotency test should pass on Travis.

Actual behaviour

provision.yml playbook passes lint but generates various warnings. We need to fix:

• Warnings related to impending breaking changes to ansible's API where become replaces sudo:

TASK [acl : Re-mount /] ********************************************************
changed: [vagrant_trusty]
[WARNING]: Consider using 'become', 'become_method', and 'become_user' rather
than running sudo

• Warnings related to usage of curl which should be replaced with get_url module
• Warnings related to usage of shell directly
• Warnings related to lack of idempotency

Notes

We need to fix these and then reinstate the Travis idempotency test which is commented out in .travis.yml