Merge pull request #1177 from getlipa/feature/remove-no-onchain-funds-error

Remove no onchain funds runtime error

Author: danielgranhao

src/errors.rs

@@ -16,8 +16,6 @@ pub enum RuntimeErrorCode {
     BackupServiceUnavailable,
     /// No backup was found for the provided mnemonic.
     BackupNotFound,
-    /// No on-chain funds are available to resolve.
-    NoOnChainFundsToResolve,
 
     // Breez runtime errors
     /// Information about the remote node isn't cached and couldn't be accessed. Could be a network error.

src/lib.rs

@@ -2191,7 +2191,7 @@ impl LightningNode {
 
     /// Returns the fees for resolving channel closes if there are enough funds to pay for fees.
     ///
-    /// Throws an [`RuntimeErrorCode::NoOnChainFundsToResolve`] error if no on-chain funds are available to resolve.
+    /// Must only be called when there are onchain funds to resolve.
     ///
     /// Returns the fee information for the available resolving options.
     ///
@@ -2209,10 +2209,7 @@ impl LightningNode {
             .as_msats();
 
         if onchain_balance.msats == 0 {
-            runtime_error!(
-                RuntimeErrorCode::NoOnChainFundsToResolve,
-                "No on-chain funds to resolve"
-            )
+            invalid_input!("No on-chain funds to resolve")
         }
 
         let lsp_fees =

src/lipalightninglib.udl

@@ -764,7 +764,6 @@ enum RuntimeErrorCode {
     "LspServiceUnavailable",
     "BackupServiceUnavailable",
     "BackupNotFound",
-    "NoOnChainFundsToResolve",
     "NodeUnavailable",
     "FailedFundMigration",
 };