-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use v-once and/or v-memo with submissions table #771
Comments
We're planning to add pagination to the submissions table, which should help a lot with performance. I'm going to go ahead and close this issue. We can always reopen it if there are issues with performance after pagination is introduced. |
As of #1043, it's no longer the case that the props of |
v-once
andv-memo
are mentioned as options for improving performance on this page. The documentation forv-memo
says:The submissions table seems like a good example of that case.
That said, I've already reduced the reactivity of the submission
requestData
. That means that the submission row components already have very few reactive dependencies. If there is limited reactivity already, wouldv-once
andv-memo
have any additional benefit? My guess is yes, because even if the submissionrequestData
is minimally reactive, the component props are still reactive: the submission row components don't know that they're used within a context that guarantees that their props are immutable.The text was updated successfully, but these errors were encountered: