Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission attachment is shown as downloadable even when it's missing #706

Open
lognaturel opened this issue Sep 10, 2024 · 1 comment
Open
Assignees

Comments

@lognaturel
Copy link
Member

Problem description

Submission attachment is shown as downloadable even when it's missing

URL of the page

https://test.getodk.cloud/#/projects/149/forms/annotate_default/submissions

Steps to reproduce the problem

Make a submission with a missing attachment (for example, in Enketo, annotate an image, scale down the canvas, submit), view the submission table

Screenshot

Screenshot 2024-09-10 at 8 42 56 AM

Expected behavior

I would expect the missing file to be displayed differently. If it's not practical to change, we could just remove the "File was submitted." from the tooltip.

Central version shown in version.txt

versions:
f21b33acc8dae215e54485849e7dd59167e6f433 (v2024.1.0)
 3fb0c22b1cbdc3a6004963afcc3847a82c09307d client (v2024.1.0)
 b4754cf52bfa64b1ca841bc9ccb64a38726398e8 server (v2024.1.0)

Browser version

Firefox

Around when did you see the problem (in UTC)?

3:44 PM
Tuesday, September 10, 2024

Other notes (if any)

@matthew-white
Copy link
Member

I would expect the missing file to be displayed differently. If it's not practical to change, we could just remove the "File was submitted." from the tooltip.

I agree that it would be ideal for the missing file to be displayed differently. Currently, that's not information available to Frontend via the OData feed. Backend returns attachmentsExpected and attachmentsPresent, so Frontend can determine the number of missing files, but not which files are missing. I'm not sure how best for Backend to return that information, though I reckon there's got to be some way. But certainly it'd be very easy to remove that text from the tooltip.

@matthew-white matthew-white self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🕒 backlog
Development

No branches or pull requests

2 participants