If a repeat has no label, improve the add repeat dialog text

[lognaturel]

• Replace "Do not add" with "Cancel"
• Use title font for prompt text, otherwise keep the prompt text the same (quotes and question mark)
• If repeat has no label (label is null), use special text "Add another?" instead of using null

https://forum.getodk.org/t/repeat-groups-add-null-repeat-dialogue-and-remove-repeat/49836

[karntrehan]

Hie @lognaturel, is this a good-first-issue? I would love to contribute some fixes to collect but currently the list for good first issues seems to be very limited: good first issue.

Do let me know how I can contribute.

[lognaturel]

Thanks for your interest, @karntrehan! Yes, this should be a straightforward one to take on.

@alyblenkin what do you think of changing the text in the case of a repeat without a label from "Add "null"?" to "Add another?" and changing the "Do not add" button to "Cancel" for now?

[alyblenkin]

Welcome @karntrehan!

@lognaturel - "Add another" and "Cancel" makes a lot more sense here! For the option to remove a repeat, it would be strange to remove from tapping on the add action, so we may need to come back to that.

I don't think the support text helps too much here, but I played around with that just to see.

[lognaturel]

it would be strange to remove from tapping on the add action, so we may need to come back to that.

Agreed!

The common case is going to be something like Add "Person" or Add "sick dog" or something like that if the form creator has specified a label for the repeat. I think we should leave that alone and only add a new case for when the label is null. Given that, do you think we should increase the font size and make the question into more of a title as you have in the mockups? The length of the label is unknown. For example it could be Add "country representative who is responsible for local healthcare decisions".

Agreed we don't need two lines of text.

[alyblenkin]

Given that, do you think we should increase the font size and make the question into more of a title as you have in the mockups? The length of the label is unknown. For example it could be Add "country representative who is responsible for local healthcare decisions".

Yes, I thought about longer titles. I wish we had a limit for labels to make it easier to read, but this is much larger piece of work, and not the actual pain point here :)

Despite the fact that in some cases titles can be lengthy, I still think we should use the title font size because it creates a stronger hierarchy of information. Here is what it would look like with your example, which is very long/not ideal, but I think better than using the body text, which seems too small for a prompt. What do you think?

[lognaturel]

Sounds good to me! I have updated the issue description.

[karntrehan]

I guess the code powering this flow is here:

collect/collect_app/src/main/java/org/odk/collect/android/formentry/repeats/AddRepeatDialog.java

Line 30 in 63050fd

alertDialog.setMessage(context.getString(org.odk.collect.strings.R.string.add_repeat_question,

I will also need to update the tests here:

collect/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/AddNewRepeatDialog.java

Line 30 in 63050fd

return clickOnTextInDialog(org.odk.collect.strings.R.string.dont_add_repeat, destination);

I have asked the OP for a sample form to test my fix here. @lognaturel would be great if you could help with that as well, else I can try creating the form at my end.

[karntrehan]

Folks the PR has been raised. Here: #6459

I have also fixed a few readme issues.