Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envelopes Serialization Improvements #4338

Closed
10 tasks done
philipphofmann opened this issue Sep 17, 2024 · 1 comment
Closed
10 tasks done

Envelopes Serialization Improvements #4338

philipphofmann opened this issue Sep 17, 2024 · 1 comment
Assignees

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Sep 17, 2024

Description

After crashing the SDK on startup due to corrupted envelope data with #4280, we must ensure this doesn't happen again. This is a meta issue to collect the improvements to achieve that goal. The plan is to increase the test coverage mainly for SentryFileManager and SentrySerialization to cover more edge cases and reduce the probability of introducing bugs by future changes to these critical classes. Furthermore, we want to double-check if some edge cases could lead to unwanted behavior.

@philipphofmann philipphofmann changed the title Improve envelopes serialization Envelopes erialization Sep 17, 2024
@philipphofmann philipphofmann changed the title Envelopes erialization Envelopes Serialization Improvements Sep 17, 2024
@philipphofmann philipphofmann self-assigned this Sep 17, 2024
@philipphofmann
Copy link
Member Author

The root cause of #4280 was crashing while deserializing a corrupted envelope. We added plenty of new tests to cover more edge cases. This should do it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant