Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable experimental swizzling of NSFileManager by default. #4880

Open
philprime opened this issue Feb 20, 2025 · 2 comments
Open

Enable experimental swizzling of NSFileManager by default. #4880

philprime opened this issue Feb 20, 2025 · 2 comments
Assignees

Comments

@philprime
Copy link
Contributor

Description

At this point in time the experimental option enableFileManagerSwizzling is set to false by default, requiring active opt-in. After gathering enough data on the stability of the stability we should enable it by default to verify stability on a larger scale. Eventually we want to refactor the experimental option as a normal swizzling option.

@philipphofmann please define the time frames/milestones, we use to perform these two changes.

@philipphofmann
Copy link
Member

@philprime, first step would be to track the adoption of the feature via the SentryEnabledFeaturesBuilder. When the option enableFileManagerSwizzling is enabled, please append it to the list, which gets added to the SDK event payload and gets indexed in Looker.

Furthermore, we should point out the feature in the docs here: https://docs.sentry.io/platforms/apple/guides/ios/tracing/instrumentation/automatic-instrumentation/#file-io-tracing and also update the docs accordingly what the current state of automatic file IO tracing is on iOS 18 and above.

We don't have strict rules, about when we can enable it per default. We need to check how many customers are using it and then also need to validate the generated data. If we are confident we're not causing major issues, we can swap the flag. The safest would be to do this in a major update.

@philprime philprime self-assigned this Feb 21, 2025
@philprime
Copy link
Contributor Author

I'll add the swizzling options to the SentryEnabledFeaturesBuilder so we can view adoptions 👍

I am already planning to update the file IO tracing docs as soon as we finalize the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

2 participants