Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 25, 2025

Fixes #4040

Not ready to merge yet, needs to be tested with test flight

#skip-changelog

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.099%. Comparing base (ca1c55d) to head (d978079).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/Swift/Core/MetricKit/SentryMXCallStackTree.swift 0.000% 59 Missing ⚠️
Sources/Sentry/SentryFormatterSwift.m 0.000% 1 Missing ⚠️
Sources/Sentry/SentryMetricKitIntegration.m 0.000% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ca1c55d) and HEAD (d978079). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (ca1c55d) HEAD (d978079)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6908        +/-   ##
=============================================
- Coverage   84.832%   7.099%   -77.733%     
=============================================
  Files          453      419        -34     
  Lines        27611    26268      -1343     
  Branches     12115     9860      -2255     
=============================================
- Hits         23423     1865     -21558     
- Misses        4142    24390     +20248     
+ Partials        46       13        -33     
Files with missing lines Coverage Δ
Sources/Sentry/SentryFormatterSwift.m 0.000% <0.000%> (ø)
Sources/Sentry/SentryMetricKitIntegration.m 0.000% <0.000%> (-100.000%) ⬇️
...s/Swift/Core/MetricKit/SentryMXCallStackTree.swift 0.000% <0.000%> (-75.000%) ⬇️

... and 432 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1c55d...d978079. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.18 ms 1259.44 ms 39.25 ms
Size 24.14 KiB 1.01 MiB 1013.45 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
079bcc8 1217.88 ms 1234.88 ms 17.00 ms
d157d83 1228.02 ms 1252.47 ms 24.45 ms
fb48c9a 1232.49 ms 1266.27 ms 33.78 ms
69edf86 1218.76 ms 1258.65 ms 39.90 ms
5db87fa 1218.88 ms 1251.53 ms 32.65 ms
a3189e5 1214.92 ms 1248.37 ms 33.45 ms
53b722c 1222.33 ms 1244.90 ms 22.56 ms
a0ed6e8 1198.02 ms 1252.20 ms 54.18 ms
1d4dad9 1232.06 ms 1264.92 ms 32.86 ms
4f36ea5 1216.87 ms 1246.34 ms 29.47 ms

App size

Revision Plain With Sentry Diff
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB
d157d83 23.75 KiB 928.85 KiB 905.10 KiB
fb48c9a 23.75 KiB 1006.34 KiB 982.59 KiB
69edf86 24.14 KiB 1.01 MiB 1010.97 KiB
5db87fa 23.75 KiB 926.65 KiB 902.90 KiB
a3189e5 24.15 KiB 1.01 MiB 1014.89 KiB
53b722c 23.75 KiB 906.08 KiB 882.33 KiB
a0ed6e8 24.15 KiB 1.01 MiB 1014.90 KiB
1d4dad9 23.75 KiB 990.00 KiB 966.26 KiB
4f36ea5 23.75 KiB 995.08 KiB 971.33 KiB

Previous results on branch: mxRewriting

Startup times

Revision Plain With Sentry Diff
8824c94 1226.98 ms 1262.65 ms 35.67 ms

App size

Revision Plain With Sentry Diff
8824c94 24.14 KiB 1.01 MiB 1014.88 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK wrongly parses MetricKit MXHangDiagnostic stack trace

2 participants