Add missing event handler (#180)

* Placeholder for missing event handler

* Guard against missing event handlers causing infinite loop

* fix: push/pop Scope on job processing

Author: stayallive

src/Sentry/Laravel/EventHandler.php

@@ -13,8 +13,10 @@
 use Illuminate\Console\Events\CommandStarting;
 use Illuminate\Console\Events\CommandFinished;
 use Illuminate\Routing\Route;
+use RuntimeException;
 use Sentry\State\Scope;
 use Sentry\Breadcrumb;
+use Sentry\State\Hub;
 
 class EventHandler
 {
@@ -98,6 +100,10 @@ public function subscribeAuthEvents(Dispatcher $events)
      */
     public function __call($method, $arguments)
     {
+        if (!method_exists($this, $method . 'handler')) {
+            throw new RuntimeException('Missing event handler:' . $method . 'handler');
+        }
+
         try {
             call_user_func_array(array($this, $method . 'handler'), $arguments);
         } catch (Exception $exception) {
@@ -132,6 +138,7 @@ protected function routerMatchedHandler(Route $route)
         ));
         Integration::setTransaction($routeName);
     }
+
     /**
      * Since Laravel 5.2
      *
@@ -142,7 +149,6 @@ protected function routeMatchedHandler(RouteMatched $match)
         $this->routerMatchedHandler($match->route);
     }
 
-
     /**
      * Since Laravel 5.2
      *
@@ -202,6 +208,9 @@ protected function authenticatedHandler(Authenticated $event)
      */
     protected function queueJobProcessingHandler(JobProcessing $event)
     {
+        // When a job starts, we want to push a new scope
+        Hub::getCurrent()->pushScope();
+
         $job = [
             'job' => $event->job->getName(),
             'queue' => $event->job->getQueue(),
@@ -223,6 +232,18 @@ protected function queueJobProcessingHandler(JobProcessing $event)
         ));
     }
 
+
+    /**
+     * Since Laravel 5.2
+     *
+     * @param \Illuminate\Queue\Events\JobProcessed $event
+     */
+    protected function queueJobProcessedHandler(JobProcessed $event)
+    {
+        // When a job finished, we want to pop the scope
+        Hub::getCurrent()->popScope();
+    }
+
     /**
      * Since Laravel 5.5
      *

test/Sentry/EventHandlerTest.php

@@ -0,0 +1,14 @@
+<?php
+
+class EventHandlerTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @expectedException \RuntimeException
+     */
+    public function test_missing_event_handler_throws_exception()
+    {
+        $handler = new \Sentry\Laravel\EventHandler([]);
+
+        $handler->thisIsNotAHandlerAndShouldThrowAnException();
+    }
+}