From 083fa84285bfefae42b227003118c4524c0f85dd Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 27 Aug 2024 14:51:41 -0700 Subject: [PATCH] change order of checks in `should_call_seer_for_grouping` --- src/sentry/grouping/ingest/seer.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/sentry/grouping/ingest/seer.py b/src/sentry/grouping/ingest/seer.py index 4c3be8eb7d2fea..52da5f0eafbc59 100644 --- a/src/sentry/grouping/ingest/seer.py +++ b/src/sentry/grouping/ingest/seer.py @@ -36,13 +36,14 @@ def should_call_seer_for_grouping(event: Event, primary_hashes: CalculatedHashes project = event.project - if not _project_has_similarity_grouping_enabled(project): - return False + # Check both of these before returning based on either so we can gather metrics on their results + content_is_eligible = event_content_is_seer_eligible(event) + seer_enabled_for_project = _project_has_similarity_grouping_enabled(project) - if _has_customized_fingerprint(event, primary_hashes): + if not (content_is_eligible and seer_enabled_for_project): return False - if not event_content_is_seer_eligible(event): + if _has_customized_fingerprint(event, primary_hashes): return False # **Do not add any new checks after this.** The rate limit check MUST remain the last of all the