Skip to content

Commit 3c2b139

Browse files
committed
Use rendering_system to enable absolute positioning of view hierarchy layout
1 parent 5f9a15d commit 3c2b139

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

static/app/components/events/viewHierarchy/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ function ViewHierarchy({viewHierarchy, project}: ViewHierarchyProps) {
219219
hierarchy={hierarchy}
220220
selectedNode={userHasSelected ? selectedNode : undefined}
221221
onNodeSelect={onWireframeNodeSelect}
222-
project={project}
222+
system={viewHierarchy.rendering_system}
223223
/>
224224
</Right>
225225
)}

static/app/components/events/viewHierarchy/wireframe.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
import {IconAdd, IconSubtract} from 'sentry/icons';
1515
import {t} from 'sentry/locale';
1616
import {space} from 'sentry/styles/space';
17-
import type {Project} from 'sentry/types/project';
1817
import {getCenterScaleMatrixFromConfigPosition} from 'sentry/utils/profiling/gl/utils';
1918
import type {Rect} from 'sentry/utils/profiling/speedscope';
2019

@@ -29,11 +28,11 @@ export interface ViewNode {
2928
type WireframeProps = {
3029
hierarchy: ViewHierarchyWindow[];
3130
onNodeSelect: (node?: ViewHierarchyWindow) => void;
32-
project: Project;
31+
system: string;
3332
selectedNode?: ViewHierarchyWindow;
3433
};
3534

36-
function Wireframe({hierarchy, selectedNode, onNodeSelect, project}: WireframeProps) {
35+
function Wireframe({hierarchy, selectedNode, onNodeSelect, system}: WireframeProps) {
3736
const theme = useTheme();
3837
const [canvasRef, setCanvasRef] = useState<HTMLCanvasElement | null>(null);
3938
const [overlayRef, setOverlayRef] = useState<HTMLCanvasElement | null>(null);
@@ -50,9 +49,9 @@ function Wireframe({hierarchy, selectedNode, onNodeSelect, project}: WireframePr
5049
() =>
5150
getHierarchyDimensions(
5251
hierarchy,
53-
['flutter', 'dart-flutter'].includes(project?.platform ?? '')
52+
system === 'flutter' || system.includes('absolute')
5453
),
55-
[hierarchy, project.platform]
54+
[hierarchy, system]
5655
);
5756
const nodeLookupMap = useMemo(() => {
5857
const map = new Map<ViewHierarchyWindow, ViewNode>();

0 commit comments

Comments
 (0)