From 55a517f4f308872beb03a1cd77a3b51d191b591e Mon Sep 17 00:00:00 2001 From: Michelle Fu Date: Tue, 27 Aug 2024 16:09:39 -0700 Subject: [PATCH] bug fix --- src/sentry/incidents/serializers/alert_rule_trigger.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/sentry/incidents/serializers/alert_rule_trigger.py b/src/sentry/incidents/serializers/alert_rule_trigger.py index e6aa7d7fffad1..8e6d97c5ab86e 100644 --- a/src/sentry/incidents/serializers/alert_rule_trigger.py +++ b/src/sentry/incidents/serializers/alert_rule_trigger.py @@ -1,3 +1,4 @@ +from django import forms from rest_framework import serializers from sentry.api.serializers.rest_framework.base import CamelSnakeModelSerializer @@ -45,6 +46,9 @@ def create(self, validated_data): self._handle_actions(alert_rule_trigger, actions) return alert_rule_trigger + except forms.ValidationError as e: + # if we fail in create_alert_rule_trigger, then only one message is ever returned + raise serializers.ValidationError(e.error_list[0].message) except AlertRuleTriggerLabelAlreadyUsedError: raise serializers.ValidationError("This label is already in use for this alert rule") @@ -56,6 +60,9 @@ def update(self, instance, validated_data): alert_rule_trigger = update_alert_rule_trigger(instance, **validated_data) self._handle_actions(alert_rule_trigger, actions) return alert_rule_trigger + except forms.ValidationError as e: + # if we fail in update_alert_rule_trigger, then only one message is ever returned + raise serializers.ValidationError(e.error_list[0].message) except AlertRuleTriggerLabelAlreadyUsedError: raise serializers.ValidationError("This label is already in use for this alert rule")