Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): Add ability to query issues by hash #76701

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Aug 28, 2024

this pr adds the ability to query by hash in the project_group_index endpoint. If a user passes in any number of hashes, the endpoint will only look for those hashes and return matching groups it finds for those hashes.

closes #72753

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 28, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 28, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/endpoints/project_group_index.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #76701     +/-   ##
=========================================
  Coverage   78.16%   78.17%             
=========================================
  Files        6901     6906      +5     
  Lines      307090   307246    +156     
  Branches    52896    50405   -2491     
=========================================
+ Hits       240047   240194    +147     
- Misses      60618    60631     +13     
+ Partials     6425     6421      -4     

@roggenkemper roggenkemper marked this pull request as ready for review August 28, 2024 22:43
@roggenkemper roggenkemper requested review from a team as code owners August 28, 2024 22:43
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, but overall LGTM!

api-docs/paths/events/project-issues.json Outdated Show resolved Hide resolved
src/sentry/api/endpoints/project_group_index.py Outdated Show resolved Hide resolved
tests/snuba/api/endpoints/test_project_group_index.py Outdated Show resolved Hide resolved
@roggenkemper roggenkemper merged commit 2d4a540 into master Aug 29, 2024
48 of 50 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/grouphash branch August 29, 2024 19:04
mifu67 pushed a commit that referenced this pull request Sep 3, 2024
this pr adds the ability to query by hash in the `project_group_index`
endpoint. If a user passes in any number of hashes, the endpoint will
only look for those hashes and return matching groups it finds for those
hashes.

closes #72753
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create API to query issues by project and GroupHash.hash value
3 participants