Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (anomaly detection): get anomalies proxy API #76707

Closed
wants to merge 8 commits into from

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Aug 28, 2024

Create a proxy for us to fetch anomalies from the frontend

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 27 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...seer/anomaly_detection/get_historical_anomalies.py 65.67% 15 Missing and 8 partials ⚠️
...nts/endpoints/organization_alert_rule_anomalies.py 88.57% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76707      +/-   ##
==========================================
+ Coverage   77.17%   78.20%   +1.03%     
==========================================
  Files        6896     6898       +2     
  Lines      306444   306573     +129     
  Branches    50230    50248      +18     
==========================================
+ Hits       236510   239770    +3260     
+ Misses      63468    60386    -3082     
+ Partials     6466     6417      -49     

@getsentry getsentry deleted a comment from github-actions bot Sep 3, 2024
@mifu67 mifu67 removed the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 3, 2024
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to make this PR a bit smaller / split into multiple?

could start with just the endpoint definition w/ placeholders, then the seer logic as a follow-on.

additionally, if this is a new endpoint, i think it is fine to have it start as EXPERIMENTAL

@mifu67
Copy link
Contributor Author

mifu67 commented Sep 3, 2024

would it be possible to make this PR a bit smaller / split into multiple?

could start with just the endpoint definition w/ placeholders, then the seer logic as a follow-on.

additionally, if this is a new endpoint, i think it is fine to have it start as EXPERIMENTAL

Sure, I can break it up

@mifu67 mifu67 closed this Sep 4, 2024
@nhsiehgit
Copy link
Contributor

closed in favor of:
#76934

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants