Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): initial styling revisions #78135

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

doralchan
Copy link
Contributor

@doralchan doralchan commented Sep 25, 2024

Gradually moving it towards the standard query UI (as agreed upon by multiple teams)

BEFORE:
Screenshot 2024-09-26 at 4 32 51 PM

AFTER:
Screenshot 2024-09-26 at 4 32 59 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/explore/content.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #78135   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files        7052     7053    +1     
  Lines      311741   311745    +4     
  Branches    50963    50964    +1     
=======================================
+ Hits       243501   243506    +5     
+ Misses      56481    56480    -1     
  Partials    11759    11759           

Copy link

codecov bot commented Sep 25, 2024

Bundle Report

Changes will decrease total bundle size by 39 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.76MB 39 bytes (-0.0%) ⬇️

@doralchan doralchan marked this pull request as ready for review September 25, 2024 21:47
@doralchan doralchan requested a review from a team as a code owner September 25, 2024 21:47
@doralchan doralchan changed the title feat(explore): initial styling bits feat(explore): initial styling revisions Sep 25, 2024
@doralchan doralchan requested a review from a team September 26, 2024 15:30
@doralchan doralchan requested review from Zylphrex and removed request for a team September 26, 2024 17:45
@doralchan doralchan force-pushed the feat/explore-initial-form branch 2 times, most recently from ad8d510 to 8047984 Compare September 26, 2024 22:39
@doralchan doralchan merged commit 5319e0d into master Sep 27, 2024
44 checks passed
@doralchan doralchan deleted the feat/explore-initial-form branch September 27, 2024 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants