Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make taskworker worker support concurrent work #80369

Closed
markstory opened this issue Nov 7, 2024 · 0 comments · Fixed by #83254
Closed

Make taskworker worker support concurrent work #80369

markstory opened this issue Nov 7, 2024 · 0 comments · Fixed by #83254
Assignees
Labels

Comments

@markstory
Copy link
Member

The current worker implementation is single threaded and will have limited throughput. Expand the worker to support concurrent processing based on CLI flags. --concurrency=12 should create 12 worker threads/processes allowing a worker to process up to 12 tasks concurrently.

Rough thinking would be to have a single thread responsible for fetching tasks and sending rpc responses back and a pool of worker threads that execute tasks. Processing timeouts could be tricky to enforce though as python threads don't have a way to do that. Perhaps celery worker has some tricks we could replicate.

@markstory markstory self-assigned this Jan 8, 2025
@linear linear bot added the Migrated label Jan 9, 2025
@markstory markstory linked a pull request Jan 10, 2025 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant