-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
new replay UI demo #104139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jerryzhou196
wants to merge
18
commits into
master
Choose a base branch
from
new-replay-ui-1-2-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
new replay UI demo #104139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary alignment property from KeyMetrics. - Introduced constants for navigation height and border styles in secondary navigation. - Refactored ReplayDetails header to use Flex layout for improved structure and styling consistency. - Updated header styles to utilize new constants for height and border, enhancing maintainability.
- Introduced conditional rendering for the header based on organization features. - Replaced the existing header with a new styled component for improved layout. - Updated styling for the new header to align with design specifications.
- Consolidated common styles for platform icons and counters. - Removed InnerWrapper and Counter components to streamline the layout. - Updated styling to enhance hover effects and maintain consistent sizing for platform icons.
…play details - Removed unnecessary common styles and consolidated styling for platform icons and counters. - Updated font sizes and weights in replay metadata for better readability. - Adjusted placeholder dimensions in replay viewers and details user badge for consistency. - Enhanced layout in replay details metadata and breadcrumbs for improved visual hierarchy.
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…d layout - Updated padding values in the StyledFlex component to enhance visual consistency and alignment with design specifications.
…e for improved layout consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REPLAY-814 - new replay UI demo
IGNORE THIS PR - this is purely to be deployed as a preview on branch