Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Tag all spans with thread info #153

Open
2 of 4 tasks
markushi opened this issue Oct 19, 2023 · 0 comments
Open
2 of 4 tasks

[EPIC] Tag all spans with thread info #153

markushi opened this issue Oct 19, 2023 · 0 comments

Comments

@markushi
Copy link
Member

markushi commented Oct 19, 2023 •
edited by kahest
Loading

For mobile starfish we want to tag all spans, indicating if the ran on the main thread or not.
The main thread flag is determined in the moment the span was started (similar to otel).

See span data conventions https://develop.sentry.dev/sdk/performance/span-data-conventions/#thread on how to add this info.

Tasks
Beta Give feedback
  1. Tag all spans with main thread flag sentry-java#2997
    Platform: Android
    markushi
  2. Tag all spans with thread info sentry-cocoa#3355
    Platform: Cocoa
    philipphofmann
@markushi markushi changed the title Tag spans with if they ran on the main thread or not [Starfish] Tag spans with if they ran on the main thread or not Oct 19, 2023
@markushi markushi changed the title [Starfish] Tag spans with if they ran on the main thread or not [Starfish] Tag all spans with main thread flag Oct 19, 2023
@philipphofmann philipphofmann changed the title [Starfish] Tag all spans with main thread flag [Starfish] Tag all spans with thread info Oct 20, 2023
@philipphofmann philipphofmann mentioned this issue Oct 20, 2023
Closed
@kahest kahest changed the title [Starfish] Tag all spans with thread info [EPIC] Tag all spans with thread info Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markushi