@@ -118,11 +118,11 @@ def test_mde_greater_than_one():
118
118
It could easily be greater than or equal to 1, like 2 for a 200% uplift. That's
119
119
not a very realistic experiment, but it should still work with our approach.
120
120
"""
121
- basemath = BaseMathsTest (0.1 , 3 , 0.05 , 0.2 , seed = "test-experiment" )
122
- assert basemath .required_samples == 47
123
- assert basemath .evaluate_experiment (0 , 12 , 0 , 15 ) == 0
124
- assert basemath .evaluate_experiment (12 , 20 , 15 , 30 ) == 0
125
- assert basemath .evaluate_experiment (32 , 8 , 45 , 10 ) == 1
121
+ basemath = BaseMathsTest (0.01 , 3 , 0.05 , 0.2 , seed = "test-experiment" )
122
+ assert basemath .required_samples == 261
123
+ assert basemath .evaluate_experiment (0 , 120 , 0 , 150 ) == 0
124
+ assert basemath .evaluate_experiment (120 , 50 , 150 , 80 ) == 0
125
+ assert basemath .evaluate_experiment (170 , 26 , 230 , 40 ) == 1
126
126
127
127
128
128
def test_first_call_concludes_experiment_failure ():
@@ -217,20 +217,6 @@ def test_negative_number_of_samples():
217
217
assert str (exception_context_manager_previous .value ) == expected_exception
218
218
219
219
220
- def test_experiment_with_negative_required_samples ():
221
- """
222
- Due to some instability in the root-finding method we use, some alpha/beta values
223
- can result in a negative number of samples. We have some basic handling for this case.
224
- """
225
- with pytest .raises (AnalysisException ) as exception_context_manager :
226
- BaseMathsTest (0.3 , 0.9 , 0.9 , 0.01 , seed = "test-experiment" )
227
- expected_exception_text = (
228
- "The provided alpha and beta values result in a negative number of required"
229
- "samples -- please reconsider your values."
230
- )
231
- assert str (exception_context_manager .value ) == expected_exception_text
232
-
233
-
234
220
def test_guarantee_crossing_bound ():
235
221
"""
236
222
If the 'line' is below the bound, then we should always fail the experiment,
0 commit comments