Skip to content

Latest commit

 

History

History
131 lines (101 loc) · 5.73 KB

CONTRIBUTING.md

File metadata and controls

131 lines (101 loc) · 5.73 KB
Raw

This document is a guide for contributions to the WGPU project.

Welcome!

First of all, welcome to the WGPU community! 👋 We're glad you want to contribute. If you are unfamiliar with the WGPU project, we recommend you read GOVERNANCE.md for an overview of its goals, and how it's governed.

Talking to other humans in the WGPU project

The WGPU project has multiple official platforms for community engagement:

  • The Matrix channel wgpu:matrix.org is dedicated to informal chat about contributions the project. It is particularly useful for:

    • Saying hello, and introducing yourself.
    • Validating contributions (i.e., determining if they'll be accepted, ensuring your approach is correct, making sure you aren't wasting effort, etc.).
    • Setting expectations for contributions.

    Notification in Matrix can sometimes be unreliable. Feel free to explicitly tag people from whom you would like attention, esp. to follow-up after a day or so if you do not get a response to your contributions.

  • GitHub issues are used to discuss open development questions and track work the community intends to complete; this might include:

    • Work that needs resolution via pull requests (see below)
      • Bug reports
      • Feature requests
      • Creating new releases of crates
    • Recording project decisions formally.
      • Architectural discussion
      • ???
    • Compiling sets of other issues needed for a specific feature or use case (AKA [meta] issues).

  • GitHub pull requests: Modifications to the contents of this repository are done through pull requests.

  • wgpu Maintainership Meetings: Every week, the maintainership of the wgpu project meets to discuss the project's direction and review ongoing work. These meetings are open to the public, and you are welcome to attend. They happen on Google Meet and happen on Wednesday at 16:00 UTC and last approximately an hour. Remember to obey the CODE_OF_CONDUCT.md in the meeting.

  • GitHub discussions: TODO: Experimentally used by some enthusiastic members of our community. Not supported officially.

Contributing to WGPU

Community response to contributions are, in general, prioritized based on their relevance to WGPU's mission and decision-making groups' interest (see GOVERNANCE.md).

"What can I work on?" as a new contributor

TODO

We discourage new contributors from submitting large changes or opinionated refactors unless they have been specifically validated by WGPU maintainership. These are likely to be rejected on basis of needing discussion before a formal review.

Setting up a WGPU development environment

We use the following components in a WGPU development environment:

Once these are done, you should be ready to hack on WGPU! Drop into your favorite editor, make some changes to the repository's code, and test that WGPU has been changed the way you expect. We recommend using a path dependency in Cargo for local testing of changes, and a git dependency pointing to your own fork to share changes with other contributors.

Once you are ready to request a review of your changes so they become part of WGPU public history, create a pull request with your changes committed to a branch in your own fork of WGPU in GitHub. See documentation for that here.

What to expect when you file an issue

TODO

  • Describe the filing process
    • Link to new issue page
    • Describe how to socialize the issue effectively
    • Feel free to ping us if it's a blocker!
    • Suggesting tags is helpful.
    • Describe how the project will handle the issue
      • Our ability to respond to an issue depends entirely on whether it is actionable (viz., that there is a course of action that is reasonable for a volunteer to take the time to do). If it's not actionable, we reserve the right to close it.
        • Being responsive to requests for further information is important.
        • Understanding what point in the repository's history an issue began is also important. Maybe link to git bisect or something similar?
        • In particular, expecting others to fix something hardware- or driver-specific that current maintainership (1) can't mentor you into fixing and (2) otherwise isn't being prioritized are likely to be closed.

What to expect when you submit a PR

TODO: It is strongly recommended that you validate your contributions before you make significant efforts…

The "Assigned" field on a PR indicates who has taken responsibility for reviewing the PR, not who is responsible for the content of the PR.