Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for creating new zip files? #1

Open
Boscop opened this issue May 21, 2020 · 3 comments
Open

Support for creating new zip files? #1

Boscop opened this issue May 21, 2020 · 3 comments

Comments

@Boscop
Copy link

Boscop commented May 21, 2020

I noticed this crate supports creating new files in a zip file, but it doesn't support creating a new zip file yet. It would be very useful to also support that :)

@icefoxen
Copy link
Contributor

Seems like the easy way would just be to use the zip crate, and anything this provides would just be a thin layer atop that. Zip files aren't really designed to be modified or created in anything other than batch mode, as far as I can tell. What kind of API would you want from such functionality?

@Boscop
Copy link
Author

Boscop commented May 25, 2020

Ideally the API would mirror the std fs API as much as possible, so that one can enable/disable whether a zip file is used or the fs is used directly, with minimal code changes (or even switchable at runtime based on a config).
E.g. things like creating/deleting dirs/files, path.exists() etc.

@icefoxen
Copy link
Contributor

Using the zip crate at least, that would involve essentially creating a new zip file from scratch on every modification. This sounds like a great way to produce more issues 6 months from now saying "file operations in a zip file are slow!" XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants