Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsaddle-warp: stopPropagation sometimes doesn't work #101

Open
tomsmalley opened this issue Aug 28, 2019 · 2 comments
Open

jsaddle-warp: stopPropagation sometimes doesn't work #101

tomsmalley opened this issue Aug 28, 2019 · 2 comments

Comments

@tomsmalley
Copy link
Contributor

e6ba1fc

This commit introduced some odd behaviour for macbooks: for us, closing a modal when an input was focused/blurred. Seems like stopPropagation is not being respected, or something - but the strange thing is it only happens when using tap to click, but not when using a mechanical click.

@tomsmalley
Copy link
Contributor Author

My suspicions of this were misplaced, actually something was broken in application code which meant this jsaddle commit altered the behaviour when it shouldn't have.

@tomsmalley
Copy link
Contributor Author

Actually I was wrong, it's just hard to reproduce :)

There appears to be a race condition which means clicks can slip through before the stopPropagation is processed. Mostly happens when under heavy network load.

This also isn't mac specific, but at one point I could repro it 100% of the time with tap to click. Must be a difference with how Safari processes click events.

@tomsmalley tomsmalley reopened this Dec 9, 2019
@tomsmalley tomsmalley changed the title jsaddle-warp: strange behaviour on macOS jsaddle-warp: stopPropagation sometimes doesn't work Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant