Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 21, 2025

fixes #589

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the title fix: Row Detail preload comp should call destroy lifecycle fix: Row Detail preload comp should call destroy lifecycle, fixes #589 Feb 21, 2025
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (578d667) to head (972547b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1025      1027    +2     
  Branches       386       386           
=========================================
+ Hits          1025      1027    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit d058102 into master Feb 21, 2025
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/preload-destroy branch February 21, 2025 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RowDetailPreloadComponent does not properly destroy itself

2 participants