Broken Fragment resolving

[dispalt]

I think it's related to this. #2491

Previously this used to work and now it doesn't, it will return only crux or crux2, starting with 2.9.1, I didn't test 2.9.0 I jumped from 2.8.1 to 2.9.1 and it broke. It's easy to reproduce on my production code, Ill see if I can work on a test case in the repo later today or tomorrow.

It seems to only show up after a certain amount of nesting.

fragment Foo on Bar {
  baz {
    crux {
      something
   }
}
}

fragment Burrito on Bar {
  baz {
    crux {
      somethingElse
    }
  }
}

query Q {
  ..Foo
  ..Burrito
}

Edited: Changed crux2 to crux

[ghostdogpr]

#2491 only modifies the validation (whether you get a validation error or not) so it shouldn't have any impact on execution. Maybe #2368 ? Could you check 2.9.0?

[dispalt]

Sure, sorry for the delay!

[dispalt]

2.9.0 seems to have the same issue., which suggests the change you highlighted might be the issue, ill try to publish local with it removed and see if it works

[kyri-petrou]

@dispalt I can't seem to be able to reproduce the issue. I tried adding this test but it's passing:

test("nested fragment selection on the same type") {
        case class A(valueA: String)
        case class B(valueB: String)
        case class Foo(a: A, b: B)
        case class Query(foo: Foo)

        implicit val schemaQuery: Schema[Any, Query] = Schema.gen

        val api = graphQL(RootResolver(Query(Foo(A("a"), B("b")))))

        val q = gqldoc("""
            fragment FragA on Query {
              foo {
                a {
                  valueA
                }
              }
            }

            fragment FragB on Query {
              foo {
                b {
                  valueB
                }
              }
            }

            query {
              ...FragA
              ...FragB
            }
            """)

        api.interpreterUnsafe.execute(q).map { res =>
          val d = res.data.toString
          assertTrue(d == """{"foo":{"a":{"valueA":"a"},"b":{"valueB":"b"}}}""")
        }
      }

Would you be able to provide a reproducer that fails the test above so I can look into it?

[dispalt]

Try this

test("nested fragment selection on the same type") {
        import caliban.schema.Schema.auto._

        case class A(valueA: String, valueC: String)
        case class B(valueB: String)
        case class Foo(a: A, b: B)
        case class Query(foo: Foo)

        val api = graphQL(RootResolver(Query(Foo(A("a", "c"), B("b")))))

        val q = gqldoc("""
            fragment FragA on Query {
              foo {
                a {
                  valueA
                  valueC
                }
              }
            }

            fragment FragB on Query {
              foo {
                a {
                  valueA
                }
                b {
                  valueB
                }
              }
            }

            query {
              ...FragA
              ...FragB
            }
            """)

        api.interpreterUnsafe.execute(q).map { res =>
          val d = res.data.toString
          assertTrue(d == """{"foo":{"a":{"valueA":"a","valueC":"c"},"b":{"valueB":"b"}}}""")
        }
      }

returns

{"foo":{"a":{"valueA":"a","valueC":"c"},"a":{"valueA":"a"},"b":{"valueB":"b"}}}

[dispalt]

yep this is exactly what I was seeing testing, thank you for the primer test case, @kyri-petrou