Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters don't initialize modes correctly #87

Open
ianhattwick opened this issue Sep 6, 2022 · 0 comments
Open

filters don't initialize modes correctly #87

ianhattwick opened this issue Sep 6, 2022 · 0 comments
Assignees
Labels

Comments

@ianhattwick
Copy link

ianhattwick commented Sep 6, 2022

I've been trying to implement highpass filters, and found that including the mode in the constructor is ineffective - but changing the mode later seems to work but also throws an error.

this should be a highpass filter (mode 1) but instead implements a lowpass filter:

s = Synth[4]('stringPad')
s.note.seq([0,2,4,1], 1/2,3/8,1/8)
s_filt = Filter({'model': 4, 'mode':1, 'cutoff': 0.05, 'Q':0})
s.fx.add(s_filt)

this correctly changes the mode to highpass but throws an error:

s = Synth[4]('stringPad')
s.note.seq([0,2,4,1], 1/2,3/8,1/8)
s_filt = Filter({'model': 4, 'mode':0, 'cutoff': 0.05, 'Q':0})
s_filt.mode = 1
s.fx.add(s_filt)
@charlieroberts charlieroberts self-assigned this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants