Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict to 4 channels, get 2x buffer #32

Open
dhiltonp opened this issue Feb 4, 2016 · 2 comments
Open

restrict to 4 channels, get 2x buffer #32

dhiltonp opened this issue Feb 4, 2016 · 2 comments

Comments

@dhiltonp
Copy link
Contributor

dhiltonp commented Feb 4, 2016

What do you think about restricting input to 4 channels? It would then be easy to double-up on memory, giving 2x the buffer space.

@markkimsal
Copy link

👍
I don't personally need to sniff more than 4 wires at a time. uart spi twi canbus all use 4 or fewer, right?

@gillham
Copy link
Owner

gillham commented May 15, 2019

I don’t know that the SUMP metadata spec allows the buffer size to change based on the sample rate. Possibly.
This would significantly complicate the code that is hand padded with nop instructions to get the timing as precise as possible.
I’ve been considering splitting the code into separate sketches for different hardware that isn’t as easily supported with #ifdef now. That might make it easier to do special versions with fewer lines and more buffer at the cost of lower sample rates as well.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants