feat: creation de la table de suivi RGPD #892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
changed the title
tonial
previously approved these changes
Jan 27, 2025
|
|
||
| @pytest.fixture(name="email_last_seen") | ||
| def fixture_email_last_seen(db): | ||
| return EmailLastSeenFactory(email=email) |
There was a problem hiding this comment.
Je ne suis pas convaincu par l'utilisation d'une fixture pour remplacer un appel à une factory : je trouve que ça rend moins clair la situation.
|
Bon, j'ai voulu juste mettre des commentaires sans approve, mais j'ai cliqué au mauvais endroit. |
This was referenced Jan 28, 2025
vincentporte
force-pushed
the
889-archivage---creation-de-la-table
branch
from
0893173 to
0532166
Compare
|
|
||
| def save(self, *args, **kwargs): | ||
| if self.email: | ||
| self.email_hash = hashlib.sha256(self.email.encode("utf-8")).hexdigest() |
There was a problem hiding this comment.
En général, pour éviter les rainbow table, on sale les hash.
There was a problem hiding this comment.
Pour éviter de hasher souvent, j’aurais uniquement calculé le hash au moment de la suppression. Hasher n’est pas gratuit. 🤷
There was a problem hiding this comment.
On pourrait mettre une contrainte pour avoir soit l'email soit le hash de renseigné
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 enregistrer, pour chaque email connu, la date de dernière action, afin de déclencher l'anonymisation des contenus au bout d'un délai défini
Type de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🚧 technique
Points d'attention
🦺 le champ
emailest unique, bien que leemaildansUserne le soit pas🦺 la méthode
savecalcul le hash de l'email🦺 la méthode
soft_deletetrace la date de deletion et supprime l'email tout en conservant le hash🦺 le hash est conservé pour comparaison ultérieure et dénombrement des déletions par jour
🦺 la méthode
seenpermet de créer ou mettre à jour le suivi d'une adresse email