-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
architecture of release binaries don't match architecture of file name #5381
Comments
Inno setup can only produce x86 installers, so getting the installer to be amd64 (or maybe even arm64) would require significant changes. But for the SFX component for Portable Git this seems pretty doable. |
Given that Delphi seems to target only Win32 and Win64 (according to this page, at least, that talks about "the 64-bit binary version of Delphi Win32 and Win64 compilers" that's not even available in community versions of Delphi), amd64 support may be possible, but arm64 support seems to be unattainable. Also, given that Git just assumes (naively, one might say) that a POSIX shell is present everywhere, and given that we do not have a Windows/ARM64-native version of |
So it sounds like, for the installers, if possible is probably false, or at least overly difficult. The installers don't run on minwin anyway for some reason (I tried with ValidationOS, which does have wow64 support). Maybe I should download an evaluation of server and do some testing with whatever core/nano configuration doesn't have wow64 support. (I saw some references to an arm64 variant of server 2025, but I can't find any way to actually download it, even from uupdump which shows updates for it but can't get enough files to construct an iso). |
I was asked to open an issue here in msys2/MINGW-packages#23182 (comment).
In general, it seems all
*.exe
assets in a git-for-windows/git release are 32-bit x86. However, in certain cases (such as WinPE, or some server core installations IIRC) WoW64 support may not be present. In those cases, Git for Windows itself would work properly, but the installer/extractor would not run. I suggest that the installer/self-extractor should be the same architecture as the contained binaries, if possible, with the possible exception that arm64 could be x86_64 since the contained msys2 there is still x86_64, so x86_64 support on the host is required for proper functioning.Workaround for PortableGit, in MSYS2:
I noticed that this project uses a custom 7zip self-extractor, and a GUI one at that (rather than the console one the above replaces it with). I guess some people really need their GUIs (though I would have expected users of Git to not be scared off by a console window)
The text was updated successfully, but these errors were encountered: