Make deepcopy of data_dict on dump adi/adx to not change provided data

Author: gitandy

src/adif_file/adi.py

@@ -1,6 +1,7 @@
 """Convert ADIF ADI content to dictionary and vice versa"""
 
 import re
+import copy
 import datetime
 from collections.abc import Iterator
 
@@ -207,6 +208,8 @@ def dumpi(data_dict: dict, comment: str = 'ADIF export by ' + __proj_name__,
     :param spaces: Number of spaces between fields
     :return: an iterator of chunks of the ADI (header, record 1, ..., record n)"""
 
+    data_dict = copy.deepcopy(data_dict)
+
     field_separator = ' ' * spaces if spaces >= 0 else ' '
 
     if 'HEADER' in data_dict:

src/adif_file/adx.py

@@ -1,6 +1,7 @@
 """Convert ADIF ADX content to dictionary and vice versa
 The XML is validated against the XSD from ADIF.org"""
 
+import copy
 import datetime
 import os.path
 import xml
@@ -92,7 +93,7 @@ def dump(file_name: str, data_dict: dict, raise_exc=True) -> list[Exception]:
        :return: list of validation exception (if not raised immediately)
        """
 
-    data_dict = data_dict.copy()
+    data_dict = copy.deepcopy(data_dict)
 
     header = {
         'ADIF_VER': '3.1.4',

test/test_dumpadx.py

@@ -182,6 +182,31 @@ def test_30_dump_no_change(self):
 
         os.remove(temp_file)
 
+    def test_40_deepcopy(self):
+        adx_dict = {
+            'HEADER': {'PROGRAMVERSION': '1',
+                       'CREATED_TIMESTAMP': '20231204 100000',
+                       },
+            'RECORDS': [{'CALL': 'XX1XXX',
+                         'QSO_DATE': '20231204',
+                         'TIME_ON': '1100',
+                         'QTH': 'Test'
+                         },
+                        {'CALL': 'YY1YYY',
+                         'QSO_DATE': '20231204',
+                         'TIME_ON': '1200',
+                         'QTH_INTL': 'Töst',
+                         }
+                        ]
+                }
+
+        temp_file = get_file_path('testdata/~test.adx')
+        adif_file.adx.dump(temp_file, adx_dict)
+        self.assertNotIn('ADIF_VER', adx_dict['HEADER'])
+        self.assertNotIn('RECORD', adx_dict['RECORDS'])
+
+        os.remove(temp_file)
+
 
 if __name__ == '__main__':
     unittest.main()