Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

AMP support for CodeFund ads #1048

Open
coderberry opened this issue Jan 23, 2020 · 9 comments
Open

AMP support for CodeFund ads #1048

coderberry opened this issue Jan 23, 2020 · 9 comments
Labels
architecture Requires architure difficulty: hard Requires extensive knowledge of the system feature request Request for a feature that does not currently exist on hold We are pausing work on this

Comments

@coderberry
Copy link
Contributor

From a publisher:

The biggest challenge I faced was the ad code is not compatible with amp pages. So I could not display ads in my amp pages. A good part of my traffic is from amp pages. The only option for me was to go back to Google Adsense. Is there any way to get Codefund ad code that is compatible with AMP?

@coderberry coderberry added the feature request Request for a feature that does not currently exist label Jan 23, 2020
@andrewmcodes
Copy link
Contributor

Need to investigate this more.

@andrewmcodes andrewmcodes added the in progress This is actively being worked on label Feb 11, 2020
@andrewmcodes andrewmcodes self-assigned this Feb 11, 2020
@andrewmcodes
Copy link
Contributor

@coderberry This appears to work fine unless I'm missing something.

andrewmcodes-archive/codefund-amp-demo@1bba39b

The Photo Blog 2020-02-11 23-30-25

@andrewmcodes
Copy link
Contributor

@jdorfman tagging you as well in case you want to be in the loop on this

@jdorfman
Copy link

@andrewmcodes is that the only template you tried?

@andrewmcodes
Copy link
Contributor

@jdorfman yes but the template should be irrelevant. I could just have an empty page with just the ad and this still should work. All you need is:

<script async custom-element="amp-script" src="https://app.codefund.io/properties/###/funder.js"></script>
<amp-script id="codefund"></amp-script>

@jdorfman
Copy link

jdorfman commented Feb 13, 2020

@andrewmcodes @coderberry I emailed the publisher who was wondering if we supported AMP.

I'll keep you posted and update the FAQ if it works.

@mishelshaji
Copy link

mishelshaji commented Feb 14, 2020

The code still has validation errors when I tested it using google amp test.
https://search.google.com/test/amp
Capture

@jdorfman
Copy link

@mishelshaji thanks for sharing. @andrewmcodes any ideas?

@andrewmcodes
Copy link
Contributor

Thanks for sharing that @mishelshaji, I didn’t know they needed to pass that test. I went back and did some more reading and this is actually a lot bigger than I thought.

AMP doesn’t allow you to use custom scripts, which means we have no way to support this currently. Also from what I’ve read, it seems you have to create your creatives in a very special way specific to AMP, and it also appears that we wouldn’t be able to record impressions without tracking users.

I’ll do some more due diligence here @jdorfman but unless I’m completely missing something that @mishelshaji can shed some light on, this isn’t something we can support unfortunately. Like I said- I’ll do some more research but wanted to let you know that we currently don’t have a way to support this.

@andrewmcodes andrewmcodes added architecture Requires architure difficulty: hard Requires extensive knowledge of the system on hold We are pausing work on this and removed in progress This is actively being worked on labels Feb 15, 2020
@andrewmcodes andrewmcodes removed their assignment Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
architecture Requires architure difficulty: hard Requires extensive knowledge of the system feature request Request for a feature that does not currently exist on hold We are pausing work on this
Projects
None yet
Development

No branches or pull requests

4 participants