Skip to content

Commit 7866107

Browse files
committed
list-objects-filter-options: make gently_parse() a file-scaope static
This function is only used from within the same file as a helper function. Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 32ed4cd commit 7866107

File tree

2 files changed

+16
-21
lines changed

2 files changed

+16
-21
lines changed

list-objects-filter-options.c

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,22 @@ const char *list_object_filter_config_name(enum list_objects_filter_choice c)
3939
BUG("list_object_filter_config_name: invalid argument '%d'", c);
4040
}
4141

42-
int gently_parse_list_objects_filter(
42+
/*
43+
* Parse value of the argument to the "filter" keyword.
44+
* On the command line this looks like:
45+
* --filter=<arg>
46+
* and in the pack protocol as:
47+
* "filter" SP <arg>
48+
*
49+
* The filter keyword will be used by many commands.
50+
* See Documentation/rev-list-options.txt for allowed values for <arg>.
51+
*
52+
* Capture the given arg as the "filter_spec". This can be forwarded to
53+
* subordinate commands when necessary (although it's better to pass it through
54+
* expand_list_objects_filter_spec() first). We also "intern" the arg for the
55+
* convenience of the current command.
56+
*/
57+
static int gently_parse_list_objects_filter(
4358
struct list_objects_filter_options *filter_options,
4459
const char *arg,
4560
struct strbuf *errbuf)

list-objects-filter-options.h

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -74,26 +74,6 @@ struct list_objects_filter_options {
7474
#define LIST_OBJECTS_FILTER_INIT { .filter_spec = STRBUF_INIT }
7575
void list_objects_filter_init(struct list_objects_filter_options *filter_options);
7676

77-
/*
78-
* Parse value of the argument to the "filter" keyword.
79-
* On the command line this looks like:
80-
* --filter=<arg>
81-
* and in the pack protocol as:
82-
* "filter" SP <arg>
83-
*
84-
* The filter keyword will be used by many commands.
85-
* See Documentation/rev-list-options.txt for allowed values for <arg>.
86-
*
87-
* Capture the given arg as the "filter_spec". This can be forwarded to
88-
* subordinate commands when necessary (although it's better to pass it through
89-
* expand_list_objects_filter_spec() first). We also "intern" the arg for the
90-
* convenience of the current command.
91-
*/
92-
int gently_parse_list_objects_filter(
93-
struct list_objects_filter_options *filter_options,
94-
const char *arg,
95-
struct strbuf *errbuf);
96-
9777
void list_objects_filter_die_if_populated(
9878
struct list_objects_filter_options *filter_options);
9979

0 commit comments

Comments
 (0)