Skip to content

feat: make gw bgp mandatory for inspect #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

feat: make gw bgp mandatory for inspect #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions pkg/hhfctl/inspect/bgp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ import (
)

type BGPIn struct {
Switches []string
Strict bool
GatewayStrict bool // TODO remove after gateway is implemented
Switches []string
Strict bool
}

type BGPOut struct {
Expand Down Expand Up @@ -140,10 +139,6 @@ func BGP(ctx context.Context, kube kclient.Reader, in BGPIn) (*BGPOut, error) {
out.Errs = append(out.Errs, fmt.Errorf("switch %s: vrf %s: unexpected neighbor %q", sw.Name, vrf, name)) //nolint:goerr113
}

if !in.GatewayStrict && neighbor.Type == apiutil.BGPNeighborTypeGateway {
continue
}

if neighbor.SessionState != v1beta1.BGPNeighborSessionStateEstablished {
out.Errs = append(out.Errs, fmt.Errorf("switch %s: vrf %s: neighbor %q is not established", sw.Name, vrf, name)) //nolint:goerr113
}
Expand Down